Pepper Message Filters: Port to use explicit permission grants in ChildProcessSecurityPolicy.

content/renderer/pepper/pepper_file_io_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_file_io_host.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
@@ skipping 176 matching lines @@
 
 int32_t PepperFileIOHost::OnHostMsgOpen(
     ppapi::host::HostMessageContext* context,
     PP_Resource file_ref_resource,
     int32_t open_flags) {
   int32_t rv = state_manager_.CheckOperationState(
       FileIOStateManager::OPERATION_EXCLUSIVE, false);
   if (rv != PP_OK)
     return rv;
 
-  int flags = 0;
+  // TODO(tommycli): Eventually just pass the Pepper flags straight to the
+  // FileSystemDispatcher so it can handle doing the security check.
+  int platform_file_flags = 0;
   open_flags_ = open_flags;
-  if (!::ppapi::PepperFileOpenFlagsToPlatformFileFlags(open_flags, &flags))
+  if (!::ppapi::PepperFileOpenFlagsToPlatformFileFlags(open_flags,
+                                                       &platform_file_flags)) {
     return PP_ERROR_BADARGUMENT;
+  }
 
   EnterResourceNoLock<PPB_FileRef_API> enter(file_ref_resource, true);
   if (enter.failed())
     return PP_ERROR_BADRESOURCE;
 
   PPB_FileRef_API* file_ref_api = enter.object();
   PP_FileSystemType type = file_ref_api->GetFileSystemType();
   if (type != PP_FILESYSTEMTYPE_LOCALPERSISTENT &&
       type != PP_FILESYSTEMTYPE_LOCALTEMPORARY &&
       type != PP_FILESYSTEMTYPE_EXTERNAL &&
       type != PP_FILESYSTEMTYPE_ISOLATED)
     return PP_ERROR_FAILED;
   file_system_type_ = type;
 
   PPB_FileRef_Impl* file_ref = static_cast<PPB_FileRef_Impl*>(file_ref_api);
   if (file_ref->HasValidFileSystem()) {
     file_system_url_ = file_ref->GetFileSystemURL();
 
     FileSystemDispatcher* file_system_dispatcher =
         ChildThread::current()->file_system_dispatcher();
     AsyncOpenFileSystemURLCallback callback = base::Bind(
         &PepperFileIOHost::ExecutePlatformOpenFileSystemURLCallback,
         weak_factory_.GetWeakPtr(),
         context->MakeReplyMessageContext());
     file_system_dispatcher->OpenFile(
-      file_system_url_, flags,
+      file_system_url_, platform_file_flags,
       base::Bind(&DidOpenFileSystemURL, callback),
       base::Bind(&DidFailOpenFileSystemURL, callback));
   } else {
     PepperHelperImpl* helper = static_cast<PepperPluginInstanceImpl*>(
         PepperPluginInstance::Get(pp_instance()))->helper();
     if (file_system_type_ != PP_FILESYSTEMTYPE_EXTERNAL || !helper)
       return PP_ERROR_FAILED;
     if (!helper->AsyncOpenFile(
-            file_ref->GetSystemPath(), flags,
+            file_ref->GetSystemPath(), open_flags,
             base::Bind(&PepperFileIOHost::ExecutePlatformOpenFileCallback,
                        weak_factory_.GetWeakPtr(),
                        context->MakeReplyMessageContext())))
       return PP_ERROR_FAILED;
   }
 
   state_manager_.SetPendingOperation(FileIOStateManager::OPERATION_EXCLUSIVE);
   return PP_OK_COMPLETIONPENDING;
 }
 
@@ skipping 290 matching lines @@
   // On the plugin side, the callback expects a parameter with different meaning
   // depends on whether is negative or not. It is the result here. We translate
   // for the callback.
   int32_t pp_error = ::ppapi::PlatformFileErrorToPepperError(error_code);
   reply_context.params.set_result(ErrorOrByteNumber(pp_error, bytes_written));
   host()->SendReply(reply_context, PpapiPluginMsg_FileIO_GeneralReply());
   state_manager_.SetOperationFinished();
 }
 
 }  // namespace content