Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/mips/ic-mips.cc

Issue 19723008: MIPS: With >= 64 non-string instance types, I removed an optimization that allowed us to detect int… (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 323
324 // Is the string an array index, with cached numeric value? 324 // Is the string an array index, with cached numeric value?
325 __ lw(hash, FieldMemOperand(key, Name::kHashFieldOffset)); 325 __ lw(hash, FieldMemOperand(key, Name::kHashFieldOffset));
326 __ And(at, hash, Operand(Name::kContainsCachedArrayIndexMask)); 326 __ And(at, hash, Operand(Name::kContainsCachedArrayIndexMask));
327 __ Branch(index_string, eq, at, Operand(zero_reg)); 327 __ Branch(index_string, eq, at, Operand(zero_reg));
328 328
329 // Is the string internalized? We know it's a string, so a single 329 // Is the string internalized? We know it's a string, so a single
330 // bit test is enough. 330 // bit test is enough.
331 // map: key map 331 // map: key map
332 __ lbu(hash, FieldMemOperand(map, Map::kInstanceTypeOffset)); 332 __ lbu(hash, FieldMemOperand(map, Map::kInstanceTypeOffset));
333 STATIC_ASSERT(kInternalizedTag != 0); 333 STATIC_ASSERT(kInternalizedTag == 0);
334 __ And(at, hash, Operand(kIsInternalizedMask)); 334 __ And(at, hash, Operand(kIsNotInternalizedMask));
335 __ Branch(not_unique, eq, at, Operand(zero_reg)); 335 __ Branch(not_unique, ne, at, Operand(zero_reg));
336 336
337 __ bind(&unique); 337 __ bind(&unique);
338 } 338 }
339 339
340 340
341 // Defined in ic.cc. 341 // Defined in ic.cc.
342 Object* CallIC_Miss(Arguments args); 342 Object* CallIC_Miss(Arguments args);
343 343
344 // The generated code does not accept smi keys. 344 // The generated code does not accept smi keys.
345 // The generated code falls through if both probes miss. 345 // The generated code falls through if both probes miss.
(...skipping 1359 matching lines...) Expand 10 before | Expand all | Expand 10 after
1705 } else { 1705 } else {
1706 ASSERT(Assembler::IsBne(branch_instr)); 1706 ASSERT(Assembler::IsBne(branch_instr));
1707 patcher.ChangeBranchCondition(eq); 1707 patcher.ChangeBranchCondition(eq);
1708 } 1708 }
1709 } 1709 }
1710 1710
1711 1711
1712 } } // namespace v8::internal 1712 } } // namespace v8::internal
1713 1713
1714 #endif // V8_TARGET_ARCH_MIPS 1714 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698