Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 19723008: MIPS: With >= 64 non-string instance types, I removed an optimization that allowed us to detect int… (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: With >= 64 non-string instance types, I removed an optimization that allowed us to detect internalized strings with a single bit test. Port r15773 (60aa9f0) Original commit message: With >= 64 non-string instance types, I removed an optimization that allowed us to detect internalized strings with a single bit test. (https://code.google.com/p/v8/source/detail?r=15358) But that change caused a regression, so here is an improvement: Put the internalized string types in the lower 64 entries of INSTANCE_TYPE, and non-internalized string types in the next 64 entries. This way we can restore the single bit check. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -34 lines) Patch
M src/mips/code-stubs-mips.cc View 5 chunks +17 lines, -28 lines 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 5 months ago (2013-07-19 13:37:08 UTC) #1
mvstanton
thanks for the port! lgtm.
7 years, 5 months ago (2013-07-19 14:26:22 UTC) #2
palfia
7 years, 5 months ago (2013-07-19 14:57:12 UTC) #3
Committed as r15783.

Powered by Google App Engine
This is Rietveld 408576698