third_party/WebKit/LayoutTests/paint/invalidation/iframe-rounding.html - Issue 1972273002: Let repaint tests test pixels by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/paint/invalidation/iframe-rounding.html

Issue 1972273002: Let repaint tests test pixels by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/repaint/resources/repaint.js ('K') | « third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-transformed-offscreen.html ('k') | third_party/WebKit/LayoutTests/paint/invalidation/invalidate-after-composited-scroll.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/paint/invalidation/iframe-rounding.html

diff --git a/third_party/WebKit/LayoutTests/paint/invalidation/iframe-rounding.html b/third_party/WebKit/LayoutTests/paint/invalidation/iframe-rounding.html

index 5337f402b42d52438cd3b9038f26904ffe909d7e..188174956cc89e6f9e02f1368b6004f6a239e151 100644

--- a/third_party/WebKit/LayoutTests/paint/invalidation/iframe-rounding.html

+++ b/third_party/WebKit/LayoutTests/paint/invalidation/iframe-rounding.html

@@ -1,5 +1,5 @@

<!DOCTYPE html>

-<script src="../../fast/repaint/resources/text-based-repaint.js"></script>

+<script src="../../fast/repaint/resources/repaint.js"></script>

<!-- The div within the iframe is at 0.5px from the iframe bounds, and the div containing the iframe is at 0.5px from the top-left of the screen.

This test checks that the latter 0.5px is rounded to 1 before being added to the 0.5px and then rounded up again to an invalidation rect. This is

because iframes are painted in rounded-int coordinates.