Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: third_party/WebKit/Source/platform/PopupMenu.h

Issue 1972243003: Merge "ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated" to M51 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/PopupMenu.h
diff --git a/third_party/WebKit/Source/platform/PopupMenu.h b/third_party/WebKit/Source/platform/PopupMenu.h
index 98a4757de10b137e5091ce52439be206edbba799..41c8f4d003c57089e82b8ff07d63453cbe4e78f7 100644
--- a/third_party/WebKit/Source/platform/PopupMenu.h
+++ b/third_party/WebKit/Source/platform/PopupMenu.h
@@ -33,7 +33,12 @@ public:
DEFINE_INLINE_VIRTUAL_TRACE() { }
virtual void show() = 0;
virtual void hide() = 0;
- virtual void updateFromElement() = 0;
+ enum UpdateReason {
+ BySelectionChange,
+ ByStyleChange,
+ ByDOMChange,
+ };
+ virtual void updateFromElement(UpdateReason) = 0;
virtual void disconnectClient() = 0;
};
« no previous file with comments | « third_party/WebKit/Source/core/loader/EmptyClients.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698