Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1972243003: Merge "ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated" to M51 (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge "ExternalPopupMenu should recreate its popup only if a SELECT subtree is updated" to M51 crbug.com/608140 happens because animation on a SELECT element causes multiple didRecalcStyle calls, and ExternalPopupMenu::updateFromElement recreates a popup by a HEAD element change. This CL adds a |reason| argument to PopupMenu::updateFromElement. It is one of BySelectionChange, ByStyleChange, and ByDOMCHange. ExternalPopupMenu doesn't recreates its popup if the |reason| is ByStyleChange because ExternalPopupMenu doesn't support styling. BUG=608140 Review-Url: https://codereview.chromium.org/1970653003 Cr-Commit-Position: refs/heads/master@{#392965} (cherry picked from commit 1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06) Committed: https://chromium.googlesource.com/chromium/src/+/b752c263dea6d780e5814be537f4a18732ac5409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -22 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 9 chunks +77 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PopupMenu.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 2 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 7 months ago (2016-05-12 23:12:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b752c263dea6d780e5814be537f4a18732ac5409.

Powered by Google App Engine
This is Rietveld 408576698