Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: content/browser/resources/media/new/media_internals.js

Issue 19722011: Added a placeholder new media-internals page under a flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
scherkus (not reviewing) 2013/07/19 18:26:13 nit: it's 2013!
2 // // Use of this source code is governed by a BSD-style license that can be
scherkus (not reviewing) 2013/07/19 18:26:13 remove comment craziness here
Ty Overby 2013/07/19 19:14:24 Done.
3 // // found in the LICENSE file.
4
5 var media = {}
6
7 var messagesReceived = 0;
scherkus (not reviewing) 2013/07/19 18:26:13 if we're not using this just remove it imo
8 var thunk = function (){
scherkus (not reviewing) 2013/07/19 18:26:13 nit: instead of "thunk" let's be a bit more descri
9 messagesReceived += 1;
10 };
11
12 media.initialize = thunk;
13 media.addAudioStream = thunk;
14 media.cacheEntriesByKey = thunk;
15 media.onReceiveEverything = thunk;
scherkus (not reviewing) 2013/07/19 18:26:13 nit: don't bother w/ the alignment
16 media.onItemDeleted = thunk;
17 media.onRendererTerminated = thunk;
18 media.onNetUpdate = thunk;
19 media.onReceiveConstants = thunk;
20 media.onMediaEvent = thunk;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698