content/browser/resources/media/new/media_internals.html - Issue 19722011: Added a placeholder new media-internals page under a flag.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/resources/media/new/media_internals.html

Issue 19722011: Added a placeholder new media-internals page under a flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/resources/media/new/media_internals.css ('K') | « content/browser/resources/media/new/media_internals.css ('k') | content/browser/resources/media/new/media_internals.js » ('j') | content/browser/resources/media/new/media_internals.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	scherkus (not reviewing) 2013/07/19 01:58:49 copyright copyright scherkus (not reviewing) 2013/07/19 01:58:49 <!DOCTYPE html> at the very top this specifies th <!DOCTYPE html> at the very top this specifies that this is indeed an HTML5 page and enables strict mode http://www.w3.org/html/wg/drafts/html/master/syntax.html#the-doctype Ty Overby 2013/07/19 17:48:00 Done. Show quoted text On 2013/07/19 01:58:49, scherkus wrote: > copyright Done. Ty Overby 2013/07/19 17:48:00 Done. Show quoted text On 2013/07/19 01:58:49, scherkus wrote: > <!DOCTYPE html> at the very top > > this specifies that this is indeed an HTML5 page and enables strict mode > http://www.w3.org/html/wg/drafts/html/master/syntax.html#the-doctype Done.
	2 <head>

	3 <link rel="stylesheet" href="media_internals.css">
	scherkus (not reviewing) 2013/07/19 01:58:49 you're missing a few other things please refer to you're missing a few other things please refer to the HTML section of the style guide http://dev.chromium.org/developers/web-development-style-guide Ty Overby 2013/07/19 17:48:00 Done. Show quoted text On 2013/07/19 01:58:49, scherkus wrote: > you're missing a few other things > > please refer to the HTML section of the style guide > http://dev.chromium.org/developers/web-development-style-guide Done.
	4 <script src="chrome://media-internals/media_internals.js"></script>

	5 <title> Media-Internals </title>
	scherkus (not reviewing) 2013/07/19 01:58:49 nit: remove spaces on the side I'd also just titl nit: remove spaces on the side I'd also just title this "Media Internals" without the - Ty Overby 2013/07/19 17:48:00 Done. Show quoted text On 2013/07/19 01:58:49, scherkus wrote: > nit: remove spaces on the side > > I'd also just title this "Media Internals" without the - Done.
	6 </head>

	7 <body>

	8 Hello World

	9 </body>

	10 </html>

OLD	NEW