Issue 19722009: Revert 212378 "Add a HistogramRecorder class and use cases."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19722009: Revert 212378 "Add a HistogramRecorder class and use cases." (Closed)

Created:
7 years, 5 months ago by Reid Kleckner

Modified:
7 years, 5 months ago

Reviewers:
lpromero

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 212378 "Add a HistogramRecorder class and use cases." This code exhibits addressability bugs under valgrind: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/26205 Please investigate and reland with a clean valgrind trybot run. > Add a HistogramRecorder class and use cases. > > This CL adds a utility class to streamline the task of testing that metrics have been updated as expected. Specifically, the HistogramRecorder class allows a client to obtain the differential value of a given histogram in the interval since the given HistogramRecorder instance was created. > > BUG=232414 > > Review URL: https://chromiumcodereview.appspot.com/18337014 TBR=lpromero@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212419

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+164 lines, -170 lines)			Patch
M	trunk/src/base/base.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/base/metrics/statistics_recorder.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
D	trunk/src/base/test/histogram_recorder.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	trunk/src/base/test/histogram_recorder.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	trunk/src/base/test/histogram_recorder_unittest.cc	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	trunk/src/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc	View	3 chunks	+67 lines, -31 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/browser/password_generation_bubble_controller_unittest.mm	View	5 chunks	+30 lines, -7 lines	0 comments	Download
M	trunk/src/net/url_request/url_request_throttler_unittest.cc	View	7 chunks	+64 lines, -15 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r212419.