Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 19722005: Do not inline printing functions typically used via GDB. (Closed)

Created:
7 years, 5 months ago by Sven Panne
Modified:
7 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Do not inline printing functions typically used via GDB. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15755

Patch Set 1 #

Patch Set 2 : Outlined things, just to be sure... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/objects.h View 1 1 chunk +2 lines, -6 lines 0 comments Download
M src/objects-printer.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
Unbreak GDB macro magic after recent optimization level changes for debug builds.
7 years, 5 months ago (2013-07-18 12:28:17 UTC) #1
Toon Verwaest
lgtm
7 years, 5 months ago (2013-07-18 13:04:30 UTC) #2
Sven Panne
7 years, 5 months ago (2013-07-18 14:41:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698