Linter version 0.1.16 bump [TBR].

lib/src/rules/dont_compare_unrelated_types_for_equality.dart

Index: lib/src/rules/dont_compare_unrelated_types_for_equality.dart
diff --git a/lib/src/rules/dont_compare_unrelated_types_for_equality.dart b/lib/src/rules/dont_compare_unrelated_types_for_equality.dart
deleted file mode 100644
index fc045604ff03a54ee969c3ed3b0cbb0eee49f561..0000000000000000000000000000000000000000
--- a/lib/src/rules/dont_compare_unrelated_types_for_equality.dart
+++ /dev/null
@@ -1,186 +0,0 @@
-// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library linter.src.rules.dont_compare_unrelated_types_for_equality;
-
-import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/dart/ast/token.dart';
-import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
-import 'package:analyzer/dart/element/type.dart';
-import 'package:linter/src/linter.dart';
-
-const String _desc = r'Equality operator (==) invocation with references of'
-    r' unrelated types.';
-
-const String _details = r'''
-
-**DON'T** Compare references of unrelated types for equality.
-Comparing references of a type where neither is a subtype of the other most
-likely will return false and might not reflect programmer's intent.
-
-**BAD:**
-```
-void someFunction() {
-  var x = '1';
-  if (x == 1) print('someFunction'); // LINT
-}
-```
-
-**BAD:**
-```
-void someFunction1() {
-  String x = '1';
-  if (x == 1) print('someFunction1'); // LINT
-}
-```
-
-**BAD:**
-```
-void someFunction13(DerivedClass2 instance) {
-  var other = new DerivedClass3();
-
-  if (other == instance) print('someFunction13'); // LINT
-}
-
-class ClassBase {}
-
-class DerivedClass1 extends ClassBase {}
-
-abstract class Mixin {}
-
-class DerivedClass2 extends ClassBase with Mixin {}
-
-class DerivedClass3 extends ClassBase implements Mixin {}
-```
-
-**GOOD:**
-```
-void someFunction2() {
-  var x = '1';
-  var y = '2';
-  if (x == y) print(someFunction2); // OK
-}
-```
-
-**GOOD:**
-```
-void someFunction3() {
-  for (var i = 0; i < 10; i++) {
-    if (i == 0) print(someFunction3); // OK
-  }
-}
-```
-
-**GOOD:**
-```
-void someFunction4() {
-  var x = '1';
-  if (x == null) print(someFunction4); // OK
-}
-```
-
-**GOOD:**
-```
-void someFunction7() {
-  List someList;
-
-  if (someList.length == 0) print('someFunction7'); // OK
-}
-```
-
-**GOOD:**
-```
-void someFunction8(ClassBase instance) {
-  DerivedClass1 other;
-
-  if (other == instance) print('someFunction8'); // OK
-}
-```
-
-**GOOD:**
-```
-void someFunction10(unknown) {
-  var what = unknown - 1;
-  for (var index = 0; index < unknown; index++) {
-    if (what == index) print('someFunction10'); // OK
-  }
-}
-```
-
-**GOOD:**
-```
-void someFunction11(Mixin instance) {
-  var other = new DerivedClass2();
-
-  if (other == instance) print('someFunction11'); // OK
-  if (other != instance) print('!someFunction11'); // OK
-}
-
-class ClassBase {}
-
-abstract class Mixin {}
-
-class DerivedClass2 extends ClassBase with Mixin {}
-```
-''';
-
-class DontCompareUnrelatedTypesForEquality extends LintRule {
-  _Visitor _visitor;
-
-  DontCompareUnrelatedTypesForEquality() : super(
-      name: 'dont_compare_unrelated_types_for_equality',
-      description: _desc,
-      details: _details,
-      group: Group.errors,
-      maturity: Maturity.experimental) {
-    _visitor = new _Visitor(this);
-  }
-
-  @override
-  AstVisitor getVisitor() => _visitor;
-}
-
-class _Visitor extends SimpleAstVisitor {
-  static const String _dartCoreLibraryName = 'dart.core';
-  static const String _boolClassName = 'bool';
-
-  final LintRule rule;
-
-  _Visitor(this.rule);
-
-  @override
-  void visitBinaryExpression(BinaryExpression node) {
-    bool isDartCoreBoolean = node.bestType.name == _boolClassName &&
-        node.bestType.element?.library?.name == _dartCoreLibraryName;
-    if (!isDartCoreBoolean || (node.operator.type != TokenType.EQ_EQ &&
-        node.operator.type != TokenType.BANG_EQ)) {
-      return;
-    }
-
-    if (_unrelatedTypes(node)) {
-      rule.reportLint(node);
-    }
-  }
-
-  bool _unrelatedTypes(BinaryExpression node) {
-    DartType leftType = node.leftOperand.bestType;
-    DartType rightType = node.rightOperand.bestType;
-    if (leftType.isBottom || leftType.isDynamic || rightType.isBottom || rightType.isDynamic) {
-      return false;
-    }
-    if (leftType == rightType ||
-        leftType.isMoreSpecificThan(rightType) ||
-        rightType.isMoreSpecificThan(leftType)) {
-      return false;
-    }
-    Element leftElement = leftType.element;
-    Element rightElement = rightType.element;
-    if (leftElement is ClassElement && rightElement is ClassElement) {
-      return leftElement.supertype.isObject ||
-          leftElement.supertype != rightElement.supertype;
-    }
-    return false;
-  }
-}