Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(41)

Issue 1972173003: Fix some TODOs in the yasm build. (Closed)

Created:
3 years, 4 months ago by brettw
Modified:
3 years, 4 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some TODOs in the yasm build. The TODO about a system yasm is not longer necessary. We don't need to support this for Chrome developers. For Linux distros, Pawel has added an overlay to change the behavior. The TODO about the output names is out-of-date. The new output location matches the names generated by the C compiler in the Chrome build. Committed: https://crrev.com/09869628d781a977987b65906856bd259e40dd9e Cr-Commit-Position: refs/heads/master@{#393544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M build/linux/unbundle/yasm.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/yasm_assemble.gni View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
3 years, 4 months ago (2016-05-12 17:19:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972173003/1
3 years, 4 months ago (2016-05-12 17:20:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 4 months ago (2016-05-12 18:27:41 UTC) #6
Paweł Hajdan Jr.
LGTM
3 years, 4 months ago (2016-05-13 10:39:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972173003/1
3 years, 4 months ago (2016-05-13 16:28:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 4 months ago (2016-05-13 16:32:51 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2016-05-13 16:34:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09869628d781a977987b65906856bd259e40dd9e
Cr-Commit-Position: refs/heads/master@{#393544}

Powered by Google App Engine
This is Rietveld 408576698