Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1972163002: Change the maximum account chooser height to 3.5 rows on Views. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the maximum account chooser height to 3.5 rows on Views. BUG=610277 Committed: https://crrev.com/51e9a92e2df9a15e1788fb55c0b85b4012026095 Cr-Commit-Position: refs/heads/master@{#393239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vaclav, please review.
4 years, 7 months ago (2016-05-12 13:04:56 UTC) #2
vabr (Chromium)
lgtm
4 years, 7 months ago (2016-05-12 13:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972163002/1
4 years, 7 months ago (2016-05-12 13:21:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 13:45:50 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 13:46:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51e9a92e2df9a15e1788fb55c0b85b4012026095
Cr-Commit-Position: refs/heads/master@{#393239}

Powered by Google App Engine
This is Rietveld 408576698