Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 197213034: Implement font-family: initial. (Closed)

Created:
6 years, 9 months ago by dglazkov
Modified:
6 years, 9 months ago
Reviewers:
eae, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Implement font-family: initial. It appears that this never worked correctly. To implement, I extracted the code we use to set initial value for document and started using it when applying initial font-family value. BUG=354110 R=eseidel,eae Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169592

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -67 lines) Patch
M LayoutTests/fast/css/font-family-initial.html View 1 chunk +2 lines, -33 lines 0 comments Download
A LayoutTests/fast/css/font-family-initial-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/fast/css/font-family-initial-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + LayoutTests/fast/css/font-family-initial-shorthand.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/css/font-family-initial-shorthand-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 1 4 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dglazkov
6 years, 9 months ago (2014-03-19 21:33:25 UTC) #1
eae
LGTM
6 years, 9 months ago (2014-03-19 21:55:42 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-19 21:55:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/197213034/20001
6 years, 9 months ago (2014-03-19 21:55:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 22:21:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-19 22:21:27 UTC) #6
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-19 22:35:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/197213034/20001
6 years, 9 months ago (2014-03-19 22:35:50 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 23:39:13 UTC) #9
Message was sent while issue was closed.
Change committed as 169592

Powered by Google App Engine
This is Rietveld 408576698