rebaseline_server: serve JSON from static file, rather than generating it live

rebaseline_server: serve JSON from static file, rather than generating it live

BUG=skia:1455, skia:2230
NOTREECHECKS=True 
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13876

[epoger, 2014-03-19 21:13:50]

Ready for review at patchset 1.

R=borenet since Ravi is out, but Ravi, if you're with us, feel free to review.

https://codereview.chromium.org/197213033/diff/1/gm/rebaseline_server/imagepa...
File gm/rebaseline_server/imagepairset.py (right):

https://codereview.chromium.org/197213033/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepairset.py:2: 
Reason for the change: We want to be able to store lots of different image diff
summaries anywhere (Google Storage, local disk, etc.) and review them anytime,
rather than requiring a rebaseline_server process to be running.  This takes us
a step in that direction.

https://codereview.chromium.org/197213033/diff/1/gm/rebaseline_server/server.py
File gm/rebaseline_server/server.py (right):

https://codereview.chromium.org/197213033/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:81: GENERATED_JSON_DIR =
os.path.join(STATIC_CONTENTS_DIR, 'generated-json')
FOR NOW we still need the server running so the client can download diff images
anyway, so this is a convenient place to serve the JSON files from.

https://codereview.chromium.org/197213033/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:247: diff_base_url=os.path.relpath(
Because this uses a relative diff_base_url, this CL depends on
https://codereview.chromium.org/205273002/ ('rebaseline_server: image URLs are
relative to JSON file's location')

https://codereview.chromium.org/197213033/diff/1/gm/rebaseline_server/server....
gm/rebaseline_server/server.py:257: self._results = new_results
Even though we no longer serve the JSON from the live Results object, we still
need to hold onto it in case the client sends us edits to apply to it.

[borenet, 2014-03-20 14:49:28]

LGTM

[epoger, 2014-03-20 15:29:22]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-20 15:29:31]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/197213033/1

[commit-bot: I haz the power, 2014-03-20 17:27:49]

Change committed as 13876