Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 197213032: Don't call hb_buffer_set_unicode_funcs in HarfBuzzShaper (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Don't call hb_buffer_set_unicode_funcs in HarfBuzzShaper Harfbuzz-ng 0.9.27 introduced a HAVE_ICU_BUILTIN define which makes the hb_buffer_set_unicode_funcs call redundant. Also call hb_buffer_clear_content instead of hb_buffer_reset which is faster now that we no longer explicitly set the unicode functions. BUG=354117 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eae
6 years, 9 months ago (2014-03-19 20:05:23 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-19 20:06:19 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-19 23:23:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197213032/1
6 years, 9 months ago (2014-03-19 23:23:35 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 00:36:47 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-20 00:36:47 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-20 00:39:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/197213032/1
6 years, 9 months ago (2014-03-20 00:40:14 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 03:49:21 UTC) #9
Message was sent while issue was closed.
Change committed as 169604

Powered by Google App Engine
This is Rietveld 408576698