Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197213029: [Android] Remove the fork of GestureDetector.java (Closed)

Created:
6 years, 9 months ago by jdduke (slow)
Modified:
6 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, daegyu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Remove the fork of GestureDetector.java This class is no longer in use, having been replaced by the new native gesture detection pipeline. BUG=332418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258356

Patch Set 1 #

Patch Set 2 : Codify some assumptions #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -722 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/lint/suppressions.xml View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java View 1 chunk +0 lines, -719 lines 0 comments Download
M ui/events/gesture_detection/gesture_detector.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_detector.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (0 generated)
jdduke (slow)
skyostil@: PTAL, thanks.
6 years, 9 months ago (2014-03-19 09:01:50 UTC) #1
Sami
Good riddance, lgtm! The findbugs warnings probably don't make sense in the new code but ...
6 years, 9 months ago (2014-03-19 10:12:29 UTC) #2
jdduke (slow)
On 2014/03/19 10:12:29, Sami wrote: > Good riddance, lgtm! > > The findbugs warnings probably ...
6 years, 9 months ago (2014-03-19 13:01:06 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-19 13:01:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/197213029/20001
6 years, 9 months ago (2014-03-19 13:01:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 13:02:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 13:02:54 UTC) #7
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-19 13:10:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/197213029/20001
6 years, 9 months ago (2014-03-19 13:10:35 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 13:12:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-19 13:12:47 UTC) #11
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-19 16:53:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/197213029/20001
6 years, 9 months ago (2014-03-19 16:54:23 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 17:07:55 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-19 17:07:56 UTC) #15
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-19 18:01:20 UTC) #16
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-19 18:01:46 UTC) #17
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 9 months ago (2014-03-19 18:01:46 UTC) #18
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-19 18:01:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/197213029/40001
6 years, 9 months ago (2014-03-19 18:04:31 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 18:10:34 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-19 18:10:35 UTC) #22
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-20 09:03:51 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/197213029/40001
6 years, 9 months ago (2014-03-20 09:04:07 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 09:23:44 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-20 09:23:44 UTC) #26
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-20 13:13:58 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/197213029/60001
6 years, 9 months ago (2014-03-20 13:14:25 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 13:30:38 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-20 13:30:38 UTC) #30
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 9 months ago (2014-03-20 14:23:02 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/197213029/80001
6 years, 9 months ago (2014-03-20 14:23:43 UTC) #32
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 18:27:14 UTC) #33
Message was sent while issue was closed. 
Change committed as 258356

Powered by Google App Engine
This is Rietveld 408576698