Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197213012: Improve media-related exception messages (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Improve media-related exception messages The two in HTMLMediaElement were just wrong. Add a video-currentTime-set-with-controller.html test as that code path was apparently untested before. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169314

Patch Set 1 #

Patch Set 2 : remove redundant TimeRanges test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -72 lines) Patch
D LayoutTests/fast/dom/time-ranges-exceptions.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/time-ranges-exceptions-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/media/track/track-cue-mutable-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/media/track/vtt-cue-exceptions-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/media/video-buffered-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
A LayoutTests/media/video-currentTime-set-with-controller.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/media/video-currentTime-set-with-controller-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/media/video-seekable-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/media/video-volume-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/TimeRanges.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-16 06:30:33 UTC) #1
Mike West
LGTM, thanks!
6 years, 9 months ago (2014-03-16 08:11:02 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-16 08:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/197213012/20001
6 years, 9 months ago (2014-03-16 08:35:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-16 09:58:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-16 09:58:06 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-16 13:03:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/197213012/20001
6 years, 9 months ago (2014-03-16 13:03:34 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-16 22:42:43 UTC) #9
Message was sent while issue was closed. 
Change committed as 169314

Powered by Google App Engine
This is Rietveld 408576698