Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/…

Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too.

TEST=run "git cl owners" on FreeBSD
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=274320

[Paweł Hajdan Jr., 2014-05-09 10:27:49]

+maruel to get a review

[cmp, 2014-05-09 16:25:34]

+szager and agable, I'm hoping one of them can review

[szager1, 2014-05-09 16:29:16]

Most of these need to be tested under msysgit.

[iannucci, 2014-05-09 17:01:52]

On 2014/05/09 16:29:16, szager1 wrote:
> Most of these need to be tested under msysgit.

Yep, that ^^^

[r.c.ladan, 2014-05-12 07:02:51]

On 2014/05/09 17:01:52, iannucci wrote:
> On 2014/05/09 16:29:16, szager1 wrote:
> > Most of these need to be tested under msysgit.
> 
> Yep, that ^^^

Any insight in how to achieve this, except for running this under Windows?

[szager1, 2014-05-12 08:21:38]

On 2014/05/12 07:02:51, r.c.ladan wrote:
> On 2014/05/09 17:01:52, iannucci wrote:
> > On 2014/05/09 16:29:16, szager1 wrote:
> > > Most of these need to be tested under msysgit.
> > 
> > Yep, that ^^^
> 
> Any insight in how to achieve this, except for running this under Windows?

I believe that running under Windows is the *only* acceptable way of testing.

[r.c.ladan, 2014-05-13 06:42:37]

On 2014/05/12 08:21:38, szager1 wrote:
> On 2014/05/12 07:02:51, r.c.ladan wrote:
> > On 2014/05/09 17:01:52, iannucci wrote:
> > > On 2014/05/09 16:29:16, szager1 wrote:
> > > > Most of these need to be tested under msysgit.
> > > 
> > > Yep, that ^^^
> > 
> > Any insight in how to achieve this, except for running this under Windows?
> 
> I believe that running under Windows is the *only* acceptable way of testing.

So copying the files to a Windows box with msysgit installed and then running
the files there (or running 'git cl presubmit') should work?

[r.c.ladan, 2014-05-13 12:26:00]

On 2014/05/13 06:42:37, r.c.ladan wrote:
> On 2014/05/12 08:21:38, szager1 wrote:
> > On 2014/05/12 07:02:51, r.c.ladan wrote:
> > > On 2014/05/09 17:01:52, iannucci wrote:
> > > > On 2014/05/09 16:29:16, szager1 wrote:
> > > > > Most of these need to be tested under msysgit.
> > > > 
> > > > Yep, that ^^^
> > > 
> > > Any insight in how to achieve this, except for running this under Windows?
> > 
> > I believe that running under Windows is the *only* acceptable way of
testing.
> 
> So copying the files to a Windows box with msysgit installed and then running
> the files there (or running 'git cl presubmit') should work?

Tried this (installing depot_tools, not chromium itself, as described in
http://dev.chromium.org/developers/how-tos/install-depot-tools
and then ran 'gclient --version' twice), this gives:

% git new-branch fixbash
% patch -p1 /path/to/patch
% git commit -a
% git cl presubmit
Running presubmit commit checks ...
Warning: not running unit tests on Windows

** Presubmit ERRORS **
OWNERS check failed: this change has no Rietveld issue number, so we can't check
it for approvals.

% git cl issue 197213008
% git cl presubmit
(gives missing LGTM for changed files)

% git cl try
git cl: error: no default try builder to try, use --bot

Am I missing something?

[r.c.ladan, 2014-05-20 11:03:59]

On 2014/05/13 12:26:00, r.c.ladan wrote:
> On 2014/05/13 06:42:37, r.c.ladan wrote:
> > On 2014/05/12 08:21:38, szager1 wrote:
> > > On 2014/05/12 07:02:51, r.c.ladan wrote:
> > > > On 2014/05/09 17:01:52, iannucci wrote:
> > > > > On 2014/05/09 16:29:16, szager1 wrote:
> > > > > > Most of these need to be tested under msysgit.
> > > > > 
> > > > > Yep, that ^^^
> > > > 
> > > > Any insight in how to achieve this, except for running this under
Windows?
> > > 
> > > I believe that running under Windows is the *only* acceptable way of
> testing.
> > 
> > So copying the files to a Windows box with msysgit installed and then
running
> > the files there (or running 'git cl presubmit') should work?
> 
> Tried this (installing depot_tools, not chromium itself, as described in
> http://dev.chromium.org/developers/how-tos/install-depot-tools
> and then ran 'gclient --version' twice), this gives:
> 
> % git new-branch fixbash
> % patch -p1 /path/to/patch
> % git commit -a
> % git cl presubmit
> Running presubmit commit checks ...
> Warning: not running unit tests on Windows
> 
> ** Presubmit ERRORS **
> OWNERS check failed: this change has no Rietveld issue number, so we can't
check
> it for approvals.
> 
> % git cl issue 197213008
> % git cl presubmit
> (gives missing LGTM for changed files)
> 
> % git cl try
> git cl: error: no default try builder to try, use --bot
> 
> Am I missing something?

Ping?

[iannucci, 2014-05-30 02:58:15]

There are no trybots for this repo. When things land, they go live on all the
bots across the fleet.

I'll give final stamp tomorrow so we can land this with eyeballs on the tree to
make sure nothing untoward happens.

[iannucci, 2014-06-02 19:58:27]

On 2014/05/30 02:58:15, iannucci wrote:
> There are no trybots for this repo. When things land, they go live on all the
> bots across the fleet.
> 
> I'll give final stamp tomorrow so we can land this with eyeballs on the tree
to
> make sure nothing untoward happens.

So... 'tomorrow' didn't work :) This is good for me on linux, smoke checking on
windows, then this can land.

[iannucci, 2014-06-02 20:29:03]

lgtm, this works on linux and windows as well.

(tried generating manpages on linux, running `git cl help`, and running `git
cache -h` on windows)

[r.c.ladan, 2014-06-02 20:29:40]

On 2014/06/02 19:58:27, iannucci wrote:
> On 2014/05/30 02:58:15, iannucci wrote:
> > There are no trybots for this repo. When things land, they go live on all
the
> > bots across the fleet.
> > 
> > I'll give final stamp tomorrow so we can land this with eyeballs on the tree
> to
> > make sure nothing untoward happens.
> 
> So... 'tomorrow' didn't work :) This is good for me on linux, smoke checking
on
> windows, then this can land.

Good to hear :) So there is no automated test to run for this kind of change?

[iannucci, 2014-06-02 20:30:20]

On 2014/06/02 20:29:03, iannucci wrote:
> lgtm, this works on linux and windows as well.
> 
> (tried generating manpages on linux, running `git cl help`, and running `git
> cache -h` on windows)

I'm going to CQ patchset #20001 (aka patchset 2), if that's alright, r.c.ladan?

[iannucci, 2014-06-02 20:31:35]

Not currently :/.  We will be building the ability to try changes like this 'for
real', but the current infrastructure's not set up to handle it (with real
representative coverage) at the moment.

[r.c.ladan, 2014-06-02 20:35:12]

On 2014/06/02 20:30:20, iannucci wrote:
> On 2014/06/02 20:29:03, iannucci wrote:
> > lgtm, this works on linux and windows as well.
> > 
> > (tried generating manpages on linux, running `git cl help`, and running `git
> > cache -h` on windows)
> 
> I'm going to CQ patchset #20001 (aka patchset 2), if that's alright,
r.c.ladan?

Yes, that is the intended patch set.

René

[iannucci, 2014-06-02 20:36:02]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-06-02 20:36:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/197213008/20001

[iannucci, 2014-06-02 20:37:10]

On 2014/06/02 20:35:12, r.c.ladan wrote:
> On 2014/06/02 20:30:20, iannucci wrote:
> > On 2014/06/02 20:29:03, iannucci wrote:
> > > lgtm, this works on linux and windows as well.
> > > 
> > > (tried generating manpages on linux, running `git cl help`, and running
`git
> > > cache -h` on windows)
> > 
> > I'm going to CQ patchset #20001 (aka patchset 2), if that's alright,
> r.c.ladan?
> 
> Yes, that is the intended patch set.
> 
> René

Landing now, trooper has been notified! :)

Thanks for the patch, sorry for the (shamefully huge) lag on this. Lack of
trybots for this stuff makes changes to it scary :/

Rob

[commit-bot: I haz the power, 2014-06-02 20:39:44]

Change committed as 274320