Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: content/renderer/media/media_stream_video_capturer_source.cc

Issue 197213004: Fix DCHECK error when invalid video constraints are set on gUM. If a video constraint can not be me… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_capturer_source.cc
diff --git a/content/renderer/media/media_stream_video_capturer_source.cc b/content/renderer/media/media_stream_video_capturer_source.cc
index 722844bdbdf806429d3903c34cbcf552a7296ac5..7100e6ef55ed9df6bbbd48bf7913c62efff8330e 100644
--- a/content/renderer/media/media_stream_video_capturer_source.cc
+++ b/content/renderer/media/media_stream_video_capturer_source.cc
@@ -44,6 +44,7 @@ VideoCapturerDelegate::VideoCapturerDelegate(
got_first_frame_(false) {
DVLOG(3) << "VideoCapturerDelegate::ctor";
DCHECK(capture_engine_);
+ message_loop_proxy_ = base::MessageLoopProxy::current();
no longer working on chromium 2014/03/13 09:29:12 move it up to the initializer.
}
VideoCapturerDelegate::~VideoCapturerDelegate() {
@@ -93,7 +94,7 @@ void VideoCapturerDelegate::StartDeliver(
const NewFrameCallback& new_frame_callback,
const StartedCallback& started_callback) {
DCHECK(params.requested_format.IsValid());
- message_loop_proxy_ = base::MessageLoopProxy::current();
+ DCHECK(message_loop_proxy_ == base::MessageLoopProxy::current());
new_frame_callback_ = new_frame_callback;
started_callback_ = started_callback;
got_first_frame_ = false;
@@ -124,7 +125,7 @@ void VideoCapturerDelegate::OnPaused(media::VideoCapture* capture) {
}
void VideoCapturerDelegate::OnError(media::VideoCapture* capture,
- int error_code) {
+ int error_code) {
DVLOG(3) << "VideoCapturerDelegate::OnError";
message_loop_proxy_->PostTask(
FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698