Fix DCHECK error when invalid video constraints are set on gUM. If a video constraint can not be me…

content/browser/media/webrtc_getusermedia_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/trace_event_impl.h"
 #include "base/json/json_reader.h"
 #include "base/strings/stringprintf.h"
 #include "base/test/trace_event_analyzer.h"
 #include "base/values.h"
 #include "content/browser/media/webrtc_internals.h"
@@ skipping 325 matching lines @@
 IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest, TwoGetUserMediaAndStop) {
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
   GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
   NavigateToURL(shell(), url);
 
   ExecuteJavascriptAndWaitForOk(
       "twoGetUserMediaAndStop({video: true, audio: true});");
 }
 
+IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,
+                       GetUserMediaWithTooHighVideoConstraintsValues) {
+  ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+
+  GURL url(embedded_test_server()->GetURL("/media/getusermedia.html"));
+
+  int large_value = 99999;

[mcasas, 2014/03/13 08:07:46]

I'd recommend splitting this test in more navigate-check
for error parts, requesting a valid but not supported 
resolution, first, and then an unsupported frame rate --
this test runs on FakeVCD which will most likely never
support beyond 180p, 240p, 360p, 480p and 720p, so what
about 800x600? FakeVCD runs at 20fps (_not_ 30fps).

[perkj_chrome, 2014/03/14 08:29:52]

Discussed of line. This test is to test what happens if the constraints are
invalid. Leave as is.

+  std::string call = GenerateGetUserMediaCall(kGetUserMediaAndStop,
+                                              large_value,
+                                              large_value,
+                                              large_value,
+                                              large_value,
+                                              large_value,
+                                              large_value);
+  NavigateToURL(shell(), url);
+
+  // TODO(perkj): A proper error code should be returned by gUM.
+  ASSERT_EQ("Error: GetUserMedia call failed with code undefined",
+            ExecuteJavascriptAndReturnResult(call));
+}
+
 // This test will make a simple getUserMedia page, verify that video is playing
 // in a simple local <video>, and for a couple of seconds, collect some
 // performance traces from VideoCaptureController colorspace conversion and
 // potential resizing.
 IN_PROC_BROWSER_TEST_F(
     WebRtcGetUserMediaBrowserTest,
     TraceVideoCaptureControllerPerformanceDuringGetUserMedia) {
   RunGetUserMediaAndCollectMeasures(
       10,
       "VideoCaptureController::OnIncomingCapturedData",
@@ skipping 84 matching lines @@
     {640, 640, 480, 480, 30, 30},
     {960, 960, 720, 720, 30, 30},
     {1280, 1280, 720, 720, 30, 30},
     {1920, 1920, 1080, 1080, 30, 30}};
 
 INSTANTIATE_TEST_CASE_P(UserMedia,
                         WebRtcConstraintsBrowserTest,
                         testing::ValuesIn(kAllUserMediaSizes));
 
 }  // namespace content