Let ReadOnlyRietveld access the password.

Let ReadOnlyRietveld access the password.

The commit queue can't successfully run presubmit checks on top of
ReadOnlyRietveld because it requires access to the password field to pass
through to presubmit_shim.

R=phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259611

[Paweł Hajdan Jr., 2014-03-21 17:48:52]

LGTM

[agable, 2014-03-25 17:12:40]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2014-03-25 17:12:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/197213003/1

[commit-bot: I haz the power, 2014-03-25 17:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 17:14:58]

Presubmit check for 197213003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1794 --:--:-- --:--:-- --:--:--  1833
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description:
foo-quux

Review URL: http://localhost:10000/5629499534213120
Closing issue (you may be prompted for your codereview password)...
Traceback (most recent call last):
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2544, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
2530, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/commit-queue/workdir/tools/depot_tools/subcommand.py", line 245, in
execute
    return command(parser, args[1:])
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1988, in CMDpush
    return SendUpstream(parser, args, 'push')
  File "/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py", line
1954, in SendUpstream
    cl.RpcServer().add_comment(cl.GetIssue(), comment)
  File "/b/commit-queue/workdir/tools/depot_tools/rietveld.py", line 255, in
add_comment
    ('no_redirect', 'True')])
  File "/b/commit-queue/workdir/tools/depot_tools/rietveld.py", line 385, in
post
    return self._send(request_path, payload=body, content_type=ctype, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/rietveld.py", line 411, in
_send
    result = self.rpc_server.Send(request_path, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
463, in Send
    f = self.opener.open(req)
  File "/usr/lib/python2.7/urllib2.py", line 406, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 444, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 403: Forbidden
FAILURE: git-cl push ok


Presubmit checks took 125.6s to calculate.

[agable, 2014-03-26 17:06:19]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2014-03-26 17:06:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/197213003/1

[commit-bot: I haz the power, 2014-03-26 17:08:52]

Change committed as 259611