Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/profiles/profile_window_browsertest.cc

Issue 1972123003: Disable ProfileWindowWebUIBrowserTest.UserManagerFocusMultipleProfiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/profile_window.h" 5 #include "chrome/browser/profiles/profile_window.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 base::Bind(&ProfileWindowWebUIBrowserTest::OnSystemProfileCreated, 261 base::Bind(&ProfileWindowWebUIBrowserTest::OnSystemProfileCreated,
262 base::Unretained(this), 262 base::Unretained(this),
263 &url_to_test, 263 &url_to_test,
264 run_loop.QuitClosure())); 264 run_loop.QuitClosure()));
265 run_loop.Run(); 265 run_loop.Run();
266 266
267 ui_test_utils::NavigateToURL(browser(), GURL(url_to_test)); 267 ui_test_utils::NavigateToURL(browser(), GURL(url_to_test));
268 EXPECT_TRUE(RunJavascriptTest("testNoPodFocused")); 268 EXPECT_TRUE(RunJavascriptTest("testNoPodFocused"));
269 } 269 }
270 270
271 // This test is flaky, see https://crbug.com/611619.
271 IN_PROC_BROWSER_TEST_F(ProfileWindowWebUIBrowserTest, 272 IN_PROC_BROWSER_TEST_F(ProfileWindowWebUIBrowserTest,
272 UserManagerFocusMultipleProfiles) { 273 DISABLED_UserManagerFocusMultipleProfiles) {
273 // The profile names are meant to sort differently by ICU collation and by 274 // The profile names are meant to sort differently by ICU collation and by
274 // naive sorting. See crbug/596280. 275 // naive sorting. See crbug/596280.
275 base::FilePath expected_path = CreateTestingProfile("#abc", "Profile 1"); 276 base::FilePath expected_path = CreateTestingProfile("#abc", "Profile 1");
276 CreateTestingProfile("?abc", "Profile 2"); 277 CreateTestingProfile("?abc", "Profile 2");
277 278
278 std::string url_to_test; 279 std::string url_to_test;
279 base::RunLoop run_loop; 280 base::RunLoop run_loop;
280 profiles::CreateSystemProfileForUserManager( 281 profiles::CreateSystemProfileForUserManager(
281 expected_path, 282 expected_path,
282 profiles::USER_MANAGER_NO_TUTORIAL, 283 profiles::USER_MANAGER_NO_TUTORIAL,
283 profiles::USER_MANAGER_SELECT_PROFILE_NO_ACTION, 284 profiles::USER_MANAGER_SELECT_PROFILE_NO_ACTION,
284 base::Bind(&ProfileWindowWebUIBrowserTest::OnSystemProfileCreated, 285 base::Bind(&ProfileWindowWebUIBrowserTest::OnSystemProfileCreated,
285 base::Unretained(this), 286 base::Unretained(this),
286 &url_to_test, 287 &url_to_test,
287 run_loop.QuitClosure())); 288 run_loop.QuitClosure()));
288 run_loop.Run(); 289 run_loop.Run();
289 290
290 ui_test_utils::NavigateToURL(browser(), GURL(url_to_test)); 291 ui_test_utils::NavigateToURL(browser(), GURL(url_to_test));
291 EXPECT_TRUE(RunJavascriptTest( 292 EXPECT_TRUE(RunJavascriptTest(
292 "testPodFocused", new base::StringValue(expected_path.AsUTF8Unsafe()))); 293 "testPodFocused", new base::StringValue(expected_path.AsUTF8Unsafe())));
293 } 294 }
294 295
295 #endif // !defined(OS_CHROMEOS) && !defined(OS_ANDROID) 296 #endif // !defined(OS_CHROMEOS) && !defined(OS_ANDROID)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698