Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1972093003: Fix RegExp.prototype.compile error case (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
dehrenberg1, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix RegExp.prototype.compile error case If the RegExp doesn't parse, then ES2015 specifies that RegExp.prototype.compile does not mutate it. This patch changes our RegExp implementation to follow that logic. R=yangguo Committed: https://crrev.com/972e852248caa129d38fea9aa2029e7fb4f57aa3 Cr-Commit-Position: refs/heads/master@{#36268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/objects.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/regexp-compile.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972093003/1
4 years, 7 months ago (2016-05-12 21:43:36 UTC) #2
Dan Ehrenberg
4 years, 7 months ago (2016-05-12 22:09:39 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 22:12:36 UTC) #5
Dan Ehrenberg
4 years, 7 months ago (2016-05-16 18:07:38 UTC) #7
Yang
On 2016/05/16 18:07:38, Dan Ehrenberg wrote: lgtm.
4 years, 7 months ago (2016-05-17 05:02:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972093003/1
4 years, 7 months ago (2016-05-17 05:48:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 06:18:15 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 06:19:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/972e852248caa129d38fea9aa2029e7fb4f57aa3
Cr-Commit-Position: refs/heads/master@{#36268}

Powered by Google App Engine
This is Rietveld 408576698