Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1972093002:
GN: Fix bootstrap.py (Closed)
DescriptionGN: Fix bootstrap.py
//base/thread_task_runner_handle.cc was moved into //base/threading/.
Also for the build to succeed it now needs //base/files/important_file_writer.cc as well.
R=brettw@chromium.org
Committed: https://crrev.com/f80bd170f853b83631da9a17803bd919a7b17204
Cr-Commit-Position: refs/heads/master@{#394528}
Patch Set 1 #Patch Set 2 : Fix bootstrap.py again #Messages
Total messages: 20 (9 generated)
Description was changed from ========== GN: Fix bootstrap.py R=brettw@chromium.org BUG= ========== to ========== GN: Fix bootstrap.py R=brettw@chromium.org ==========
Please, add a brieft description of what are you fixing in the CL description. So future readers doing archeologia do not need to actually look at the diff of your patch to understand why the change was made. Thanks,
On 2016/05/18 11:35:36, tfarina wrote: > Please, add a brieft description of what are you fixing > in the CL description. > > So future readers doing archeologia do not need to > actually look at the diff of your patch to understand why > the change was made. > > Thanks, It gets out of sync with base all the time and needs minor corrections to the file list. Many of the commits on this file just say "Fix GN bootstrap".
Description was changed from ========== GN: Fix bootstrap.py R=brettw@chromium.org ========== to ========== GN: Fix bootstrap.py //base/thread_task_runner_handle.cc was renamed //base/threading/thread_task_runner_handle.cc. Also build needed //base/files/important_file_writer.cc R=brettw@chromium.org ==========
On 2016/05/18 11:38:35, kal wrote: > On 2016/05/18 11:35:36, tfarina wrote: > > Please, add a brieft description of what are you fixing > > in the CL description. > > > > So future readers doing archeologia do not need to > > actually look at the diff of your patch to understand why > > the change was made. > > > > Thanks, > > It gets out of sync with base all the time and needs minor corrections to the > file list. Many of the commits on this file just say "Fix GN bootstrap". Updated...
Description was changed from ========== GN: Fix bootstrap.py //base/thread_task_runner_handle.cc was renamed //base/threading/thread_task_runner_handle.cc. Also build needed //base/files/important_file_writer.cc R=brettw@chromium.org ========== to ========== GN: Fix bootstrap.py //base/thread_task_runner_handle.cc was moved into //base/threading/. Also for the build to succeed it now needs //base/files/important_file_writer.cc as well. R=brettw@chromium.org ==========
On 2016/05/18 11:45:27, kal wrote: > On 2016/05/18 11:38:35, kal wrote: > > On 2016/05/18 11:35:36, tfarina wrote: > > > Please, add a brieft description of what are you fixing > > > in the CL description. > > > > > > So future readers doing archeologia do not need to > > > actually look at the diff of your patch to understand why > > > the change was made. > > > > > > Thanks, > > > > It gets out of sync with base all the time and needs minor corrections to the > > file list. Many of the commits on this file just say "Fix GN bootstrap". > > Updated... It's still usually a better idea to be more descriptive.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by kcconley@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972093002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
The CQ bit was checked by kcconley@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972093002/20001
Message was sent while issue was closed.
Description was changed from ========== GN: Fix bootstrap.py //base/thread_task_runner_handle.cc was moved into //base/threading/. Also for the build to succeed it now needs //base/files/important_file_writer.cc as well. R=brettw@chromium.org ========== to ========== GN: Fix bootstrap.py //base/thread_task_runner_handle.cc was moved into //base/threading/. Also for the build to succeed it now needs //base/files/important_file_writer.cc as well. R=brettw@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== GN: Fix bootstrap.py //base/thread_task_runner_handle.cc was moved into //base/threading/. Also for the build to succeed it now needs //base/files/important_file_writer.cc as well. R=brettw@chromium.org ========== to ========== GN: Fix bootstrap.py //base/thread_task_runner_handle.cc was moved into //base/threading/. Also for the build to succeed it now needs //base/files/important_file_writer.cc as well. R=brettw@chromium.org Committed: https://crrev.com/f80bd170f853b83631da9a17803bd919a7b17204 Cr-Commit-Position: refs/heads/master@{#394528} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f80bd170f853b83631da9a17803bd919a7b17204 Cr-Commit-Position: refs/heads/master@{#394528} |
