[MD History] Make history-list:historyData private.

chrome/browser/resources/md_history/history_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-list',
 
   properties: {
     searchedTerm: {
       type: String,
       value: '',
     },
 
     lastSearchedTerm_: String,
 
     querying: Boolean,
 
     // An array of history entries in reverse chronological order.
-    historyData: Array,
+    historyData_: Array,
 
     resultLoadingDisabled_: {
       type: Boolean,
       value: false,
     },
   },
 
   listeners: {
     'infinite-list.scroll': 'closeMenu_',
     'tap': 'closeMenu_',
@@ skipping 28 matching lines @@
   },
 
   /**
    * Disables history result loading when there are no more history results.
    */
   disableResultLoading: function() {
     this.resultLoadingDisabled_ = true;
   },
 
   /**
-   * Adds the newly updated history results into historyData. Adds new fields
+   * Adds the newly updated history results into historyData_. Adds new fields
    * for each result.
    * @param {!Array<!HistoryEntry>} historyResults The new history results.
    */
   addNewResults: function(historyResults) {
     /** @type {IronScrollThresholdElement} */(this.$['scroll-threshold'])
         .clearTriggers();
 
     if (this.lastSearchedTerm_ != this.searchedTerm) {
       this.resultLoadingDisabled_ = false;
-      if (this.historyData)
-        this.splice('historyData', 0, this.historyData.length);
+      if (this.historyData_)
+        this.splice('historyData_', 0, this.historyData_.length);
       this.lastSearchedTerm_ = this.searchedTerm;
     }
 
     if (historyResults.length == 0)
       return;
 
     // Creates a copy of historyResults to prevent accidentally modifying this
     // field.
     var results = historyResults.slice();
 
     var currentDate = results[0].dateRelativeDay;
 
     for (var i = 0; i < results.length; i++) {
       // Sets the default values for these fields to prevent undefined types.
       results[i].selected = false;
       results[i].readableTimestamp =
           this.searchedTerm == '' ?
               results[i].dateTimeOfDay : results[i].dateShort;
 
       if (results[i].dateRelativeDay != currentDate) {
         currentDate = results[i].dateRelativeDay;
       }
     }
 
-    if (this.historyData) {
+    if (this.historyData_) {
       // If we have previously received data, push the new items onto the
       // existing array.
-      results.unshift('historyData');
+      results.unshift('historyData_');
       this.push.apply(this, results);
     } else {
       // The first time we receive data, use set() to ensure the iron-list is
       // initialized correctly.
-      this.set('historyData', results);
+      this.set('historyData_', results);
     }
   },
 
   /**
-   * Cycle through each entry in historyData and set all items to be
+   * Cycle through each entry in historyData_ and set all items to be
    * unselected.
    * @param {number} overallItemCount The number of checkboxes selected.
    */
   unselectAllItems: function(overallItemCount) {
-    if (this.historyData === undefined)
+    if (this.historyData_ === undefined)
       return;
 
-    for (var i = 0; i < this.historyData.length; i++) {
-      if (this.historyData[i].selected) {
-        this.set('historyData.' + i + '.selected', false);
+    for (var i = 0; i < this.historyData_.length; i++) {
+      if (this.historyData_[i].selected) {
+        this.set('historyData_.' + i + '.selected', false);
         overallItemCount--;
         if (overallItemCount == 0)
           break;
       }
     }
   },
 
   /**
    * Remove all selected items from the overall array so that they are also
    * removed from view. Make sure that the card length and positioning is
    * updated accordingly.
    * @param {number} overallItemCount The number of items selected.
    */
   removeDeletedHistory: function(overallItemCount) {
     var splices = [];
-    for (var i = this.historyData.length - 1; i >= 0; i--) {
-      if (!this.historyData[i].selected)
+    for (var i = this.historyData_.length - 1; i >= 0; i--) {
+      if (!this.historyData_[i].selected)
         continue;
 
-      // Removes the selected item from historyData. Use unshift so |splices|
+      // Removes the selected item from historyData_. Use unshift so |splices|
       // ends up in index order.
       splices.unshift({
         index: i,
-        removed: [this.historyData[i]],
+        removed: [this.historyData_[i]],
         addedCount: 0,
-        object: this.historyData,
+        object: this.historyData_,
         type: 'splice'
       });
-      this.historyData.splice(i, 1);
+      this.historyData_.splice(i, 1);
 
       overallItemCount--;
       if (overallItemCount == 0)
         break;
     }
     // notifySplices gives better performance than individually splicing as it
     // batches all of the updates together.
-    this.notifySplices('historyData', splices);
+    this.notifySplices('historyData_', splices);
   },
 
   /**
    * Based on which items are selected, collect an array of the info required
    * for chrome.send('removeHistory', ...).
    * @param {number} count The number of items that are selected.
    * @return {Array<HistoryEntry>} toBeRemoved An array of objects which contain
    * information on which history-items should be deleted.
    */
   getSelectedItems: function(count) {
     var toBeRemoved = [];
-    for (var i = 0; i < this.historyData.length; i++) {
-      if (this.historyData[i].selected) {
+    for (var i = 0; i < this.historyData_.length; i++) {
+      if (this.historyData_[i].selected) {
         toBeRemoved.push({
-          url: this.historyData[i].url,
-          timestamps: this.historyData[i].allTimestamps
+          url: this.historyData_[i].url,
+          timestamps: this.historyData_[i].allTimestamps
         });
 
         count--;
         if (count == 0)
           break;
       }
     }
     return toBeRemoved;
   },
 
   /**
    * Called when the page is scrolled to near the bottom of the list.
    * @private
    */
   loadMoreData_: function() {
     if (this.resultLoadingDisabled_ || this.querying)
       return;
 
     this.fire('load-more-history');
   },
 
   /**
    * Check whether the time difference between the given history item and the
    * next one is large enough for a spacer to be required.
    * @param {HistoryEntry} item
-   * @param {number} index The index of |item| in |historyData|.
-   * @param {number} length The length of |historyData|.
+   * @param {number} index The index of |item| in |historyData_|.
+   * @param {number} length The length of |historyData_|.
    * @return {boolean} Whether or not time gap separator is required.
    * @private
    */
   needsTimeGap_: function(item, index, length) {
     if (index >= length - 1 || length == 0)
       return false;
 
-    var currentItem = this.historyData[index];
-    var nextItem = this.historyData[index + 1];
+    var currentItem = this.historyData_[index];
+    var nextItem = this.historyData_[index + 1];
 
     if (this.searchedTerm)
       return currentItem.dateShort != nextItem.dateShort;
 
     return currentItem.time - nextItem.time > BROWSING_GAP_TIME &&
         currentItem.dateRelativeDay == nextItem.dateRelativeDay;
   },
 
-  hasResults: function(historyDataLength) {
-    return historyDataLength > 0;
+  hasResults: function(historyData_Length) {

[tsergeant, 2016/05/18 06:44:02]

Nit: I would probably leave this one alone, it looks a bit weird.

[calamity, 2016/05/18 07:14:16]

Fiiiiiine.

+    return historyData_Length > 0;
   },
 
   noResultsMessage_: function(searchedTerm, isLoading) {
     if (isLoading)
       return '';
     var messageId = searchedTerm !== '' ? 'noSearchResults' : 'noResults';
     return loadTimeData.getString(messageId);
   },
 
   /**
    * True if the given item is the beginning of a new card.
    * @param {HistoryEntry} item
-   * @param {number} i Index of |item| within |historyData|.
+   * @param {number} i Index of |item| within |historyData_|.
    * @param {number} length
    * @return {boolean}
    * @private
    */
   isCardStart_: function(item, i, length) {
     if (length == 0 || i > length - 1)
       return false;
     return i == 0 ||
-        this.historyData[i].dateRelativeDay !=
-        this.historyData[i - 1].dateRelativeDay;
+        this.historyData_[i].dateRelativeDay !=
+        this.historyData_[i - 1].dateRelativeDay;
   },
 
   /**
    * True if the given item is the end of a card.
    * @param {HistoryEntry} item
-   * @param {number} i Index of |item| within |historyData|.
+   * @param {number} i Index of |item| within |historyData_|.
    * @param {number} length
    * @return {boolean}
    * @private
    */
   isCardEnd_: function(item, i, length) {
     if (length == 0 || i > length - 1)
       return false;
     return i == length - 1 ||
-        this.historyData[i].dateRelativeDay !=
-        this.historyData[i + 1].dateRelativeDay;
+        this.historyData_[i].dateRelativeDay !=
+        this.historyData_[i + 1].dateRelativeDay;
   },
 });