core/fxcrt/include/fx_string.h - Issue 1972053003: Add CFX_ByteStringC::CharAt() to avoid c_str() and casts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/fx_string.h

Issue 1972053003: Add CFX_ByteStringC::CharAt() to avoid c_str() and casts (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/include/fx_string.h

diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h

index fbfb91f759620264b485c37756066299ddf25788..8db84dd2478f0d03cb0c90d3061600c698d8e615 100644

--- a/core/fxcrt/include/fx_string.h

+++ b/core/fxcrt/include/fx_string.h

@@ -99,6 +99,9 @@ class CFX_ByteStringC {

bool IsEmpty() const { return m_Length == 0; }

uint8_t GetAt(FX_STRSIZE index) const { return m_Ptr[index]; }

+ FX_CHAR CharAt(FX_STRSIZE index) const {

+ return static_cast<FX_CHAR>(m_Ptr[index]);

+ }

FX_STRSIZE Find(FX_CHAR ch) const {

const uint8_t* found =

« no previous file with comments | « core/fxcrt/fx_xml_composer.cpp ('k') | xfa/fee/fde_txtedtengine.cpp » ('j') | no next file with comments »