core/fxcrt/fx_basic_bstring.cpp - Issue 1972053003: Add CFX_ByteStringC::CharAt() to avoid c_str() and casts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_bstring.cpp

Issue 1972053003: Add CFX_ByteStringC::CharAt() to avoid c_str() and casts (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic_bstring.cpp

diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp

index 18e240bc84d48166fdd81a85edf9e85f917ef227..e035dd53d1cf0a86bc40c681201dc19d75ef9253 100644

--- a/core/fxcrt/fx_basic_bstring.cpp

+++ b/core/fxcrt/fx_basic_bstring.cpp

@@ -99,9 +99,8 @@ CFX_ByteString::CFX_ByteString(char ch) {

}

CFX_ByteString::CFX_ByteString(const CFX_ByteStringC& stringSrc) {

- if (!stringSrc.IsEmpty()) {

+ if (!stringSrc.IsEmpty())

m_pData.Reset(StringData::Create(stringSrc.c_str(), stringSrc.GetLength()));

- }

}

CFX_ByteString::CFX_ByteString(const CFX_ByteStringC& str1,

« no previous file with comments | « core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp ('k') | core/fxcrt/fx_basic_gcc.cpp » ('j') | no next file with comments »