chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h - Issue 1972033002: Simplify some old avatar menu button code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

Issue 1972033002: Simplify some old avatar menu button code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

index 7fc8ec93150c1389d1258246e725bc519d4cc60f..c10b0df3b09e6d06372cf547be3635eed18c240f 100644

--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h

@@ -74,7 +74,7 @@ class BrowserNonClientFrameViewAsh : public BrowserNonClientFrameView,

protected:

// BrowserNonClientFrameView:

- void UpdateAvatar() override;

+ void UpdateProfileIcons() override;

private:

FRIEND_TEST_ALL_PREFIXES(BrowserNonClientFrameViewAshTest, WindowHeader);

@@ -114,8 +114,7 @@ class BrowserNonClientFrameViewAsh : public BrowserNonClientFrameView,

// accoutrements.

bool UseWebAppHeaderStyle() const;

- // Layout the avatar button.

- void LayoutAvatar();

+ void LayoutProfileIndicator();

Peter Kasting 2016/05/18 02:44:01 Nit: Should this be LayoutProfileIndicatorIcon()?

Evan Stade 2016/05/20 22:04:43 Done.

// Returns true if there is anything to paint. Some fullscreen windows do not

// need their frames painted.