Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4060)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 1972033002: Simplify some old avatar menu button code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index 239af2508e525b680a96fee4272d5336fc932e01..89234e2f60ca6a333c9dd53c30b646ce5c628f3e 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -17,7 +17,7 @@
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h"
#include "chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h"
-#include "chrome/browser/ui/views/profiles/avatar_menu_button.h"
+#include "chrome/browser/ui/views/profiles/profile_indicator_icon.h"
#include "chrome/browser/ui/views/tab_icon_view.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
@@ -188,8 +188,8 @@ gfx::Rect OpaqueBrowserFrameView::GetWindowBoundsForClientBounds(
bool OpaqueBrowserFrameView::IsWithinAvatarMenuButtons(
const gfx::Point& point) const {
- if (avatar_button() &&
- avatar_button()->GetMirroredBounds().Contains(point)) {
+ if (profile_indicator() &&
+ profile_indicator()->GetMirroredBounds().Contains(point)) {
return true;
}
if (profile_switcher_.view() &&
@@ -380,10 +380,6 @@ bool OpaqueBrowserFrameView::ShouldShowCaptionButtons() const {
return ShouldShowWindowTitleBar();
}
-bool OpaqueBrowserFrameView::ShouldShowAvatar() const {
- return browser_view()->ShouldShowAvatar();
-}
-
bool OpaqueBrowserFrameView::IsRegularOrGuestSession() const {
return browser_view()->IsRegularOrGuestSession();
}
@@ -462,11 +458,11 @@ bool OpaqueBrowserFrameView::ShouldPaintAsThemed() const {
platform_observer_->IsUsingSystemTheme();
}
-void OpaqueBrowserFrameView::UpdateAvatar() {
+void OpaqueBrowserFrameView::UpdateProfileIcons() {
if (browser_view()->IsRegularOrGuestSession())
profile_switcher_.Update(AvatarButtonStyle::THEMED);
else
- UpdateOldAvatarButton();
+ UpdateProfileIndicatorIcon();
}
///////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698