Simplify some old avatar menu button code.

chrome/browser/ui/views/frame/browser_non_client_frame_view.h

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view.h
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view.h b/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
index 5ea8e7c6f736b20cb92dc24df3bcbe4c173410dd..c9e0d09f7ed3ef40d27c6de52edd9e7cb5e9991d 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
@@ -6,9 +6,9 @@
 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_NON_CLIENT_FRAME_VIEW_H_
 
 #include "chrome/browser/profiles/profile_attributes_storage.h"
+#include "chrome/browser/ui/views/profiles/profile_indicator_icon.h"
 #include "ui/views/window/non_client_view.h"
 
-class AvatarMenuButton;
 class BrowserFrame;
 class BrowserView;
 
@@ -22,7 +22,6 @@ class BrowserNonClientFrameView : public views::NonClientFrameView,
 
   BrowserView* browser_view() const { return browser_view_; }
   BrowserFrame* frame() const { return frame_; }
-  AvatarMenuButton* avatar_button() const { return avatar_button_; }
 
   // Called when BrowserView creates all it's child views.
   virtual void OnBrowserViewInitViewsComplete();
@@ -83,11 +82,13 @@ class BrowserNonClientFrameView : public views::NonClientFrameView,
   gfx::ImageSkia GetFrameOverlayImage() const;
 
   // Update the profile switcher button if one should exist. Otherwise, update

[Peter Kasting, 2016/05/17 03:51:42]

Nit: While here: Update -> Updates (2 places)

[Evan Stade, 2016/05/17 18:13:09]

Done.

-  // the incognito avatar, or profile avatar for teleported frames in ChromeOS.
-  virtual void UpdateAvatar() = 0;
+  // the icon that indicates incognito (or a teleported window in ChromeOS).
+  virtual void UpdateProfileIcons() = 0;
 
-  // Updates the title and icon of the old avatar button.
-  void UpdateOldAvatarButton();
+  // Updates the icon that indicates incognito/teleportation state.
+  void UpdateProfileIndicatorIcon();
+
+  views::View* profile_indicator() const { return profile_indicator_; }

[Peter Kasting, 2016/05/17 03:51:42]

Const accessors shouldn't return non-const pointers; either make this non-const
or have it return a const pointer.

[Evan Stade, 2016/05/17 18:13:09]

Done.

 
  private:
   // views::NonClientFrameView:
@@ -114,9 +115,9 @@ class BrowserNonClientFrameView : public views::NonClientFrameView,
   // The BrowserView hosted within this View.
   BrowserView* browser_view_;
 
-  // Menu button that displays the incognito icon. May be null for some frame
-  // styles. TODO(anthonyvd): simplify/rename.
-  AvatarMenuButton* avatar_button_ = nullptr;
+  // On desktop, this is used to show an incognito indicator. On CrOS, it's also

[Peter Kasting, 2016/05/17 03:51:42]

Nit: indicator -> icon?

[Evan Stade, 2016/05/17 18:13:09]

Done.

+  // used for teleported windows (in multi-profile mode).
+  ProfileIndicatorIcon* profile_indicator_ = nullptr;

[Peter Kasting, 2016/05/17 03:51:42]

Nit: I would make the type name and member name match exactly, whatever you
choose.

It's also a bit weird to me to use an initializer here in the declaration for
this variable but not the other members... would kinda prefer changing them all
(or else none)

[Evan Stade, 2016/05/17 18:13:09]

done
well, I did change none :). But I'll move this one to the initializer list.

 
   DISALLOW_COPY_AND_ASSIGN(BrowserNonClientFrameView);
 };