Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: ppapi/tests/test_talk_private.cc

Issue 197203004: Fix "unreachable code" warnings (MSVC warning 4702) in ppapi/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_file_mapping.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_talk_private.cc
===================================================================
--- ppapi/tests/test_talk_private.cc (revision 256983)
+++ ppapi/tests/test_talk_private.cc (working copy)
@@ -55,12 +55,9 @@
PASS();
}
-#if defined(USE_ASH)
// Under Ash, this will prompt the user so the test cannot run in an automated
- // fashion. To manually test under Ash, comment this out.
- PASS();
-#endif
-
+ // fashion. To manually test under Ash, replace "!defined(USE_ASH)" with 1.
+#if !defined(USE_ASH)
PP_Resource talk_resource = talk_private_interface_1->Create(
instance_->pp_instance());
@@ -79,6 +76,6 @@
if (callback.result() != 0)
return "Unexpected non-zero result";
#endif
-
+#endif
PASS();
}
« no previous file with comments | « ppapi/tests/test_file_mapping.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698