Issue 197203003: Consider intrinsic size for SVG as list-style-image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197203003: Consider intrinsic size for SVG as list-style-image (Closed)

Created:
6 years, 9 months ago by fs

Modified:
6 years, 9 months ago

Reviewers:
leviw_travelin_and_unemployed, pdr., ojan

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Consider intrinsic size for SVG as list-style-image When using an SVG as list marker image, don't unconditionally set the dimensions to a square with the dimensions of ascent / 2, but rather determine a suitable size using intrinsic dimensions (and ratio). This aligns behavior with Gecko and IE. BUG=350734 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169053

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -1 line)			Patch
A	LayoutTests/svg/as-list-image/svg-list-image-intrinsic-size-1.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/as-list-image/svg-list-image-intrinsic-size-1-expected.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderListMarker.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/197203003/1

6 years, 9 months ago (2014-03-12 18:45:24 UTC) #3

Message was sent while issue was closed.

Change committed as 169053

Expand Messages | Collapse Messages