Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: ios/web/web_state/web_state_delegate_bridge_unittest.mm

Issue 1972013003: Add ContextMenuCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split unittest suite up into multiple tests. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_state_delegate_bridge_unittest.mm
diff --git a/ios/web/web_state/web_state_delegate_bridge_unittest.mm b/ios/web/web_state/web_state_delegate_bridge_unittest.mm
index b78ad06f3713276f6a427e9c9c6765d864240e5a..32b49d575a14d833908a73640be85b9e1eb17e92 100644
--- a/ios/web/web_state/web_state_delegate_bridge_unittest.mm
+++ b/ios/web/web_state/web_state_delegate_bridge_unittest.mm
@@ -53,7 +53,7 @@ TEST_F(WebStateDelegateBridgeTest, HandleContextMenu) {
contextMenuParams.link_url = GURL("http://www.url.com");
contextMenuParams.src_url = GURL("http://www.url.com/image.jpeg");
contextMenuParams.referrer_policy = web::ReferrerPolicyOrigin;
- contextMenuParams.view = [UIView new];
+ contextMenuParams.view.reset([UIView new]);
Eugene But (OOO till 7-30) 2016/05/20 21:26:46 NIT: since you touching this could you please s/ne
michaeldo 2016/05/23 21:19:08 I'll fix and make a seperate cl :)
contextMenuParams.location = CGPointMake(5.0, 5.0);
bridge_->HandleContextMenu(nullptr, contextMenuParams);
web::ContextMenuParams* resultParams = [delegate_ contextMenuParams];

Powered by Google App Engine
This is Rietveld 408576698