Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: ios/chrome/browser/ui/context_menu/context_menu_wrangler.h

Issue 1972013003: Add ContextMenuCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to CL comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_WRANGLER_H_
6 #define IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_WRANGLER_H_
7
8 #import <UIKit/UIKit.h>
9
10 #include "base/ios/block_types.h"
11
12 namespace web {
13 struct ContextMenuParams;
14 }
15
16 // Abstracts displaying context menus for all device form factors. Will show a
17 // sheet on the phone and use a popover on a tablet.
18 @interface ContextMenuWrangler : NSObject
19
20 // Whether the context menu is visible.
21 @property(nonatomic, readonly, getter=isVisible) BOOL visible;
Eugene But (OOO till 7-30) 2016/05/13 01:23:55 Is this method actually needed?
michaeldo 2016/05/17 18:03:03 It is needed (for now). It is used downstream, I c
22
23 // Initializes with details provided in |params|.
24 - (instancetype)initWithContextMenuParams:(const web::ContextMenuParams&)params;
marq (ping after 24h) 2016/05/13 14:51:29 I'd like coordinators to typically accept a view c
michaeldo 2016/05/17 18:03:03 Done.
25 // Adds an item at the end of the menu.
26 - (void)addItemWithTitle:(NSString*)title action:(ProceduralBlock)action;
27 // Displays the context menu.
28 - (void)present;
marq (ping after 24h) 2016/05/13 14:51:29 The coordinator's job is to manage a discrete UI i
michaeldo 2016/05/17 18:03:03 Done.
29
30 // Dismisses displayed context menu.
31 - (void)dismissAnimated:(BOOL)animated
marq (ping after 24h) 2016/05/13 14:51:29 What's the use case for this being called by exter
michaeldo 2016/05/17 18:03:03 This appears to only be called from "dismissModals
32 completionHandler:(ProceduralBlock)completionHandler;
33
34 @end
35
36 #endif // IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_WRANGLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698