Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: ios/chrome/browser/ui/context_menu/context_menu_wrangler.h

Issue 1972013003: Add ContextMenuCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove old files. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_WRANGLER_H_
6 #define IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_WRANGLER_H_
7
8 #include "base/ios/block_types.h"
9 #import "ios/chrome/browser/ui/context_menu/context_menu_controller.h"
10
11 namespace web {
12 struct ContextMenuParams;
13 }
14
15 // Abstracts displaying context menus for all device form factors, given a
16 // ContextMenuHolder with the title and action to associate to each menu
Eugene But (OOO till 7-30) 2016/05/12 22:27:48 Please update comments, it does not use take Conte
michaeldo 2016/05/12 23:32:43 Done.
17 // item. Will show a sheet on the phone and use a popover on a tablet.
18 @interface ContextMenuWrangler : ContextMenuController
Eugene But (OOO till 7-30) 2016/05/12 22:27:48 Probably there is no need for subclassing.
michaeldo 2016/05/12 23:32:43 Done.
19
20 // Initialize with details provided in |params|.
Eugene But (OOO till 7-30) 2016/05/12 22:27:48 s/Initialize/Initializes
michaeldo 2016/05/12 23:32:43 Done.
21 - (instancetype)initWithContextMenuParams:(const web::ContextMenuParams&)params;
22 // Adds an item at the end of the menu.
23 - (void)appendItemWithTitle:(NSString*)title action:(ProceduralBlock)action;
Eugene But (OOO till 7-30) 2016/05/12 22:27:48 s/append/add ? which is a common add action in Obj
michaeldo 2016/05/12 23:32:43 I think you're right. Add seems better. Append is
24 // Displays the context menu.
25 - (void)present;
26
27 // Dismisses displayed context menu.
28 - (void)dismissAnimated:(BOOL)animated
29 completionHandler:(ProceduralBlock)completionHandler;
30
31 @end
32
33 #endif // IOS_CHROME_BROWSER_UI_CONTEXT_MENU_CONTEXT_MENU_WRANGLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698