Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1971963003: Serializing <keygen> and <track> should not generate end tags. (Closed)

Created:
4 years, 7 months ago by wychen
Modified:
4 years, 7 months ago
Reviewers:
tkent, mdjones, ramya.v
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Serializing <keygen> and <track> should not generate end tags. Spec: https://html.spec.whatwg.org/multipage/syntax.html#serialising-html-fragments Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/2b5538e628...0adf24afe4 Picked up changes: 0adf24a <track> should not have end tags BUG=521771 Committed: https://crrev.com/fa742b7351d8d751e9c4fd2602ec0b1cf2913086 Cr-Commit-Position: refs/heads/master@{#393383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -231 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/html/syntax/serializing-html-fragments/outerHTML-expected.txt View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/html/syntax/serializing-xml-fragments/outerHTML-expected.txt View 1 chunk +0 lines, -114 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971963003/1
4 years, 7 months ago (2016-05-12 18:43:32 UTC) #2
wychen
Moved from https://codereview.chromium.org/1967493002/ because Ramya had difficulties merging the other CL (https://codereview.chromium.org/1971023002/).
4 years, 7 months ago (2016-05-12 19:52:49 UTC) #4
wychen
PTAL
4 years, 7 months ago (2016-05-12 19:54:06 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 19:56:30 UTC) #9
mdjones
lgtm
4 years, 7 months ago (2016-05-12 20:15:23 UTC) #10
tkent
lgtm
4 years, 7 months ago (2016-05-12 20:38:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971963003/1
4 years, 7 months ago (2016-05-12 22:46:24 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 22:50:49 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 22:52:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa742b7351d8d751e9c4fd2602ec0b1cf2913086
Cr-Commit-Position: refs/heads/master@{#393383}

Powered by Google App Engine
This is Rietveld 408576698