Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1971923004: Add calls to the offliner and unit tests. (Closed)

Created:
4 years, 7 months ago by Pete Williamson
Modified:
4 years, 7 months ago
Reviewers:
dougarnett
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add calls to the offliner and unit tests. This forwards calls that make it to the request coordinator on to the offliner. BUG=610521 Committed: https://crrev.com/c2711bdfc2538ba6814466d1fc1165acde286717 Cr-Commit-Position: refs/heads/master@{#393699}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix memory leak #

Total comments: 13

Patch Set 4 : CR feedback per DougArnett #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -11 lines) Patch
M components/offline_pages/background/offliner.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.h View 1 2 3 3 chunks +15 lines, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 1 2 3 3 chunks +35 lines, -7 lines 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 1 2 3 5 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Pete Williamson
4 years, 7 months ago (2016-05-12 18:46:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971923004/1
4 years, 7 months ago (2016-05-12 20:53:14 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/160674)
4 years, 7 months ago (2016-05-12 21:48:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971923004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971923004/40001
4 years, 7 months ago (2016-05-13 16:54:02 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 18:30:55 UTC) #12
dougarnett
I'd like to avoid "prerender" terminology into the Coordinator unless there is a good reason ...
4 years, 7 months ago (2016-05-13 19:33:00 UTC) #13
Pete Williamson
https://codereview.chromium.org/1971923004/diff/40001/components/offline_pages/background/offliner.h File components/offline_pages/background/offliner.h (right): https://codereview.chromium.org/1971923004/diff/40001/components/offline_pages/background/offliner.h#newcode24 components/offline_pages/background/offliner.h:24: NO_STATUS_YET = 4, On 2016/05/13 19:33:00, dougarnett wrote: > ...
4 years, 7 months ago (2016-05-13 22:28:24 UTC) #14
dougarnett
lgtm https://codereview.chromium.org/1971923004/diff/40001/components/offline_pages/background/request_coordinator.cc File components/offline_pages/background/request_coordinator.cc (right): https://codereview.chromium.org/1971923004/diff/40001/components/offline_pages/background/request_coordinator.cc#newcode78 components/offline_pages/background/request_coordinator.cc:78: Offliner* prerendererOffliner = factory_->GetOffliner(policy_.get()); On 2016/05/13 22:28:24, Pete ...
4 years, 7 months ago (2016-05-13 22:56:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971923004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971923004/60001
4 years, 7 months ago (2016-05-13 23:01:02 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-14 00:16:15 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 00:17:06 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c2711bdfc2538ba6814466d1fc1165acde286717
Cr-Commit-Position: refs/heads/master@{#393699}

Powered by Google App Engine
This is Rietveld 408576698