Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: test/browser/language_tests.js

Issue 1971923003: Mark some tests that could be fail instead of skip_fail as fail. Mark timeout test as timeout inste… (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/language_tests.js
diff --git a/test/browser/language_tests.js b/test/browser/language_tests.js
index 15d5b7c9b63ce3f6df2050b9c00434dd61eb2ae8..0346a4bff3a7cbe369af91310776971c7e67d596 100644
--- a/test/browser/language_tests.js
+++ b/test/browser/language_tests.js
@@ -461,7 +461,7 @@
// TODO(jmesserly): this could be a failure we didn't notice before
// because we now call the right Dart double.toString, resulting in a
// difference between -0.0 and 0?
- 'chunked_conversion_json_encode1_test': skip_fail,
+ 'chunked_conversion_json_encode1_test': fail,
// TODO(rnystrom): A lot of the convert tests timeout. Some do pass if
// you increase the time by a large amount, but it's pretty gratuitous.
@@ -472,8 +472,8 @@
'chunked_conversion_utf8_test': skip_timeout,
// TODO(rnystrom): Strong mode cast failures.
- 'codec1_test': skip_fail,
- 'encoding_test': skip_fail,
+ 'codec1_test': fail,
+ 'encoding_test': skip_timeout,
'html_escape_test': fail,
// TODO(rnystrom): If this test is enabled, karma gets confused and
@@ -483,7 +483,7 @@
'json_utf8_chunk_test': skip_timeout,
// TODO(rnystrom): Strong mode cast failure.
- 'line_splitter_test': skip_fail,
+ 'line_splitter_test': fail,
'streamed_conversion_json_encode1_test': skip_timeout,
'streamed_conversion_json_utf8_decode_test': skip_timeout,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698