Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: test/browser/language_tests.js

Issue 1971923003: Mark some tests that could be fail instead of skip_fail as fail. Mark timeout test as timeout inste… (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 'use strict'; 6 'use strict';
7 7
8 let dart_sdk = dart_library.import('dart_sdk'); 8 let dart_sdk = dart_library.import('dart_sdk');
9 dart_sdk._isolate_helper.startRootIsolate(function() {}, []); 9 dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
10 let async_helper = dart_library.import('async_helper').async_helper; 10 let async_helper = dart_library.import('async_helper').async_helper;
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 'throw_half_surrogate_pair_test_01_multi': fail, 454 'throw_half_surrogate_pair_test_01_multi': fail,
455 // TODO(rnystrom): Times out because it tests a huge number of 455 // TODO(rnystrom): Times out because it tests a huge number of
456 // combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200). 456 // combinations of URLs (4 * 5 * 5 * 8 * 6 * 6 * 4 = 115200).
457 'uri_parse_test': skip_timeout, 457 'uri_parse_test': skip_timeout,
458 }, 458 },
459 459
460 'lib/convert': { 460 'lib/convert': {
461 // TODO(jmesserly): this could be a failure we didn't notice before 461 // TODO(jmesserly): this could be a failure we didn't notice before
462 // because we now call the right Dart double.toString, resulting in a 462 // because we now call the right Dart double.toString, resulting in a
463 // difference between -0.0 and 0? 463 // difference between -0.0 and 0?
464 'chunked_conversion_json_encode1_test': skip_fail, 464 'chunked_conversion_json_encode1_test': fail,
465 465
466 // TODO(rnystrom): A lot of the convert tests timeout. Some do pass if 466 // TODO(rnystrom): A lot of the convert tests timeout. Some do pass if
467 // you increase the time by a large amount, but it's pretty gratuitous. 467 // you increase the time by a large amount, but it's pretty gratuitous.
468 // I'm not sure why they are so slow. One guess is that they are spewing 468 // I'm not sure why they are so slow. One guess is that they are spewing
469 // a ton of warnings, that slow down the test. 469 // a ton of warnings, that slow down the test.
470 'chunked_conversion_utf84_test': skip_timeout, 470 'chunked_conversion_utf84_test': skip_timeout,
471 'chunked_conversion_utf88_test': skip_timeout, 471 'chunked_conversion_utf88_test': skip_timeout,
472 'chunked_conversion_utf8_test': skip_timeout, 472 'chunked_conversion_utf8_test': skip_timeout,
473 473
474 // TODO(rnystrom): Strong mode cast failures. 474 // TODO(rnystrom): Strong mode cast failures.
475 'codec1_test': skip_fail, 475 'codec1_test': fail,
476 'encoding_test': skip_fail, 476 'encoding_test': skip_timeout,
477 'html_escape_test': fail, 477 'html_escape_test': fail,
478 478
479 // TODO(rnystrom): If this test is enabled, karma gets confused and 479 // TODO(rnystrom): If this test is enabled, karma gets confused and
480 // disconnects randomly. 480 // disconnects randomly.
481 'json_lib_test': skip_fail, 481 'json_lib_test': skip_fail,
482 482
483 'json_utf8_chunk_test': skip_timeout, 483 'json_utf8_chunk_test': skip_timeout,
484 484
485 // TODO(rnystrom): Strong mode cast failure. 485 // TODO(rnystrom): Strong mode cast failure.
486 'line_splitter_test': skip_fail, 486 'line_splitter_test': fail,
487 487
488 'streamed_conversion_json_encode1_test': skip_timeout, 488 'streamed_conversion_json_encode1_test': skip_timeout,
489 'streamed_conversion_json_utf8_decode_test': skip_timeout, 489 'streamed_conversion_json_utf8_decode_test': skip_timeout,
490 'streamed_conversion_json_utf8_encode_test': skip_timeout, 490 'streamed_conversion_json_utf8_encode_test': skip_timeout,
491 'streamed_conversion_utf8_decode_test': skip_timeout, 491 'streamed_conversion_utf8_decode_test': skip_timeout,
492 'streamed_conversion_utf8_encode_test': skip_timeout, 492 'streamed_conversion_utf8_encode_test': skip_timeout,
493 'utf85_test': skip_timeout, 493 'utf85_test': skip_timeout,
494 }, 494 },
495 495
496 // TODO(jacobr): enable more of the html tests in unittest once they have 496 // TODO(jacobr): enable more of the html tests in unittest once they have
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
819 819
820 for (let action of unittest_tests) { 820 for (let action of unittest_tests) {
821 try { 821 try {
822 action(); 822 action();
823 } catch (e) { 823 } catch (e) {
824 console.error("Caught error tying to setup test:", e); 824 console.error("Caught error tying to setup test:", e);
825 } 825 }
826 } 826 }
827 }); 827 });
828 })(); 828 })();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698