Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1971923003: Mark some tests that could be fail instead of skip_fail as fail. Mark timeout test as timeout inste… (Closed)

Created:
4 years, 7 months ago by Jacob
Modified:
4 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark some tests that could be fail instead of skip_fail as fail. Mark timeout test as timeout instead of skip_fail BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a4f62cc685418bc41426ff1e539982fea2e9be93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/browser/language_tests.js View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 7 months ago (2016-05-12 16:35:20 UTC) #2
Bob Nystrom
lgtm
4 years, 7 months ago (2016-05-12 16:36:49 UTC) #3
Jacob
4 years, 7 months ago (2016-05-12 16:39:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4f62cc685418bc41426ff1e539982fea2e9be93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698