Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: lib/src/query_selector.dart

Issue 1971923002: Make package:html strong clean (Closed) Base URL: git@github.com:dart-lang/html.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/list_proxy.dart ('k') | lib/src/tokenizer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/query_selector.dart
diff --git a/lib/src/query_selector.dart b/lib/src/query_selector.dart
index e586d1aa593b1d259c698760996c570793b55f9c..3aa45f296121f23bcf86bb2fced429d24f91310b 100644
--- a/lib/src/query_selector.dart
+++ b/lib/src/query_selector.dart
@@ -3,6 +3,7 @@ library html.src.query;
import 'package:csslib/parser.dart' as css;
import 'package:csslib/parser.dart' show TokenKind;
+import 'package:csslib/src/messages.dart' show Message;
import 'package:csslib/visitor.dart'; // the CSSOM
import 'package:html/dom.dart';
import 'package:html/src/constants.dart' show isWhitespaceCC;
@@ -14,7 +15,7 @@ Element querySelector(Node node, String selector) =>
new SelectorEvaluator().querySelector(node, _parseSelectorList(selector));
List<Element> querySelectorAll(Node node, String selector) {
- var results = [];
+ var results = <Element>[];
new SelectorEvaluator().querySelectorAll(
node, _parseSelectorList(selector), results);
return results;
@@ -22,7 +23,7 @@ List<Element> querySelectorAll(Node node, String selector) {
// http://dev.w3.org/csswg/selectors-4/#grouping
SelectorGroup _parseSelectorList(String selector) {
- var errors = [];
+ var errors = <Message>[];
var group = css.parseSelectorGroup(selector, errors: errors);
if (group == null || errors.isNotEmpty) {
throw new FormatException("'$selector' is not a valid selector: $errors");
« no previous file with comments | « lib/src/list_proxy.dart ('k') | lib/src/tokenizer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698