Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1971863002: Make PixelGetters much smaller, move more common code to PixelAccessor. (Closed)

Created:
4 years, 7 months ago by herb_g
Modified:
4 years, 7 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make PixelGetters much smaller, move more common code to PixelAccessor. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1971863002 Committed: https://skia.googlesource.com/skia/+/15332a841d7b65774bc5dbcdfeec3a954a655895

Patch Set 1 #

Patch Set 2 : Sync #

Patch Set 3 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -211 lines) Patch
M src/core/SkLinearBitmapPipeline.cpp View 5 chunks +21 lines, -13 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_sample.h View 1 2 2 chunks +157 lines, -198 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
herb_g
This is the last cleanup CL. Next are the rest of the Source accessors.
4 years, 7 months ago (2016-05-11 20:06:01 UTC) #4
herb_g
Sync
4 years, 7 months ago (2016-05-11 20:18:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971863002/20001
4 years, 7 months ago (2016-05-11 20:19:32 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 20:42:04 UTC) #9
f(malita)
lgtm
4 years, 7 months ago (2016-05-12 17:17:43 UTC) #10
herb_g
Sync
4 years, 7 months ago (2016-05-12 18:11:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971863002/40001
4 years, 7 months ago (2016-05-12 18:12:26 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 18:37:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/15332a841d7b65774bc5dbcdfeec3a954a655895

Powered by Google App Engine
This is Rietveld 408576698