Move IOThread::LoggingNetworkChangeObserver to net/base

Move IOThread::LoggingNetworkChangeObserver to net/base

Other targets would like to use this besides Chrome.
So move it to net/base so targets like Cronet can use it.

BUG=610293
Committed: https://crrev.com/7b34e529fc6e5b705be1dfb6df2ab854d169b899
Cr-Commit-Position: refs/heads/master@{#393305}

[pauljensen, 2016-05-12 15:24:48]

pauljensen@chromium.org changed reviewers:
+ mmenke@chromium.org

[pauljensen, 2016-05-12 15:24:48]

Matt, PTAL.

[mmenke, 2016-05-12 16:47:58]

LGTM.

Would be nice if we could just have the NCN log stuff itself, but that gets a
bit weird - IOThread currently creates and owns the ChromeNetLog, but the NCN
itself is created content-side.

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
File net/base/logging_network_change_observer.cc (right):

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
net/base/logging_network_change_observer.cc:25: VLOG(1) << "Observed a change to
the network IP addresses";
need base/logging.h.

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
net/base/logging_network_change_observer.cc:32: std::string type_as_string =
include <string>

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
File net/base/logging_network_change_observer.h (right):

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
net/base/logging_network_change_observer.h:40:
DISALLOW_COPY_AND_ASSIGN(LoggingNetworkChangeObserver);
nit:  Blank line before DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/1971853002/diff/40001/net/net.gypi
File net/net.gypi (right):

https://codereview.chromium.org/1971853002/diff/40001/net/net.gypi#newcode38
net/net.gypi:38: 'base/logging_network_change_observer.h',
Need to be in the non-nacl list

[pauljensen, 2016-05-12 16:52:56]

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
File net/base/logging_network_change_observer.cc (right):

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
net/base/logging_network_change_observer.cc:25: VLOG(1) << "Observed a change to
the network IP addresses";
On 2016/05/12 16:47:58, mmenke wrote:
> need base/logging.h.

Done.

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
net/base/logging_network_change_observer.cc:32: std::string type_as_string =
On 2016/05/12 16:47:58, mmenke wrote:
> include <string>

Done.

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
File net/base/logging_network_change_observer.h (right):

https://codereview.chromium.org/1971853002/diff/40001/net/base/logging_networ...
net/base/logging_network_change_observer.h:40:
DISALLOW_COPY_AND_ASSIGN(LoggingNetworkChangeObserver);
On 2016/05/12 16:47:58, mmenke wrote:
> nit:  Blank line before DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/1971853002/diff/40001/net/net.gypi
File net/net.gypi (right):

https://codereview.chromium.org/1971853002/diff/40001/net/net.gypi#newcode38
net/net.gypi:38: 'base/logging_network_change_observer.h',
On 2016/05/12 16:47:58, mmenke wrote:
> Need to be in the non-nacl list

Done.

[pauljensen, 2016-05-12 17:22:59]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2016-05-12 17:23:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1971853002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-12 17:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971853002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971853002/80001

[commit-bot: I haz the power, 2016-05-12 18:21:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-12 18:22:08]

Description was changed from

==========
Move IOThread::LoggingNetworkChangeObserver to net/base

Other targets would like to use this besides Chrome.
So move it to net/base so targets like Cronet can use it.

BUG=610293
==========

to

==========
Move IOThread::LoggingNetworkChangeObserver to net/base

Other targets would like to use this besides Chrome.
So move it to net/base so targets like Cronet can use it.

BUG=610293

Committed: https://crrev.com/7b34e529fc6e5b705be1dfb6df2ab854d169b899
Cr-Commit-Position: refs/heads/master@{#393305}
==========

[commit-bot: I haz the power, 2016-05-12 18:22:09]

Patchset 5 (id:??) landed as
https://crrev.com/7b34e529fc6e5b705be1dfb6df2ab854d169b899
Cr-Commit-Position: refs/heads/master@{#393305}