Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1971843002: Fix paint invalidation rect of LayoutView (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, trchen
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix paint invalidation rect of LayoutView The bug was caused by http://crrev.com/1929413002 which uses selfVisualOverflowRect() instead of visualOverflowRect() to calculate paint invalidation rect. It caused wrong paint invalidation rect for LayoutView. Before rootLayerScrolls is launched, LayoutView's overflow model is special. We should calculate its paint invalidation rect based on its special visualOverflowRect() for now. BUG=611046 Committed: https://crrev.com/c053f70ee05c2dd91bf8b9da324e2a631e356bdc Cr-Commit-Position: refs/heads/master@{#393099}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/background-image-paint-invalidation-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Xianzhu
4 years, 7 months ago (2016-05-11 20:58:19 UTC) #3
Xianzhu
For the try bot layout test failures, the actual results are like the expected results ...
4 years, 7 months ago (2016-05-11 20:59:35 UTC) #4
trchen
Makes sense to me. lgtm.
4 years, 7 months ago (2016-05-11 22:18:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971843002/20001
4 years, 7 months ago (2016-05-11 22:20:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 23:12:11 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 23:13:59 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c053f70ee05c2dd91bf8b9da324e2a631e356bdc
Cr-Commit-Position: refs/heads/master@{#393099}

Powered by Google App Engine
This is Rietveld 408576698