net/tools/tld_cleanup/README - Issue 197183002: Reduce footprint of registry controlled domain table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/tld_cleanup/README

Issue 197183002: Reduce footprint of registry controlled domain table (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed shebang and execution bits Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/tld_cleanup/README

diff --git a/net/tools/tld_cleanup/README b/net/tools/tld_cleanup/README

index a7f137d7660f88d4babb8e8b0a222246d39c63b7..13614700e4224e01e45508ce6f2b8e7dc4d5dc21 100644

--- a/net/tools/tld_cleanup/README

+++ b/net/tools/tld_cleanup/README

@@ -20,12 +20,9 @@ When updating src/net/base/registry_controlled_domains/effective_tld_names.dat:

src/build/Debug. It will re-generate

src/net/base/registry_controlled_domains/effective_tld_names.gperf.

-6. Run gperf on the new effective_tld_names.gperf:

- pushd src/net/base/registry_controlled_domains;

- gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -P -K name_offset -D -m 10 \

- effective_tld_names.gperf > effective_tld_names.cc;

- popd;

- It will produce a new effective_tld_names.cc.

+6. Check in the updated effective_tld_names.dat, effective_tld_names.gperf

-7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,

- and effective_tld_names.cc together.

+Note that gperf is no longer used for effective_tld_names, but when building

+chromium the file effective_tld_names.gperf will be parsed by make_dafsa.py

+to generate the file effective_tld_names-inc.cc, which is included in

+registry_controlled_domain.cc

« no previous file with comments | « net/tools/tld_cleanup/PRESUBMIT.py ('k') | net/tools/tld_cleanup/make_dafsa.py » ('j') | no next file with comments »