Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: net/tools/tld_cleanup/PRESUBMIT.py

Issue 197183002: Reduce footprint of registry controlled domain table (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed more style issues and doc strings Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/tld_cleanup/PRESUBMIT.py
diff --git a/net/tools/tld_cleanup/PRESUBMIT.py b/net/tools/tld_cleanup/PRESUBMIT.py
new file mode 100755
index 0000000000000000000000000000000000000000..1f12184f94fa7bfe03e6799979fad28757dcf629
--- /dev/null
+++ b/net/tools/tld_cleanup/PRESUBMIT.py
@@ -0,0 +1,40 @@
+#!/usr/bin/env python
+
M-A Ruel 2014/05/02 16:53:02 I meant to remove the empty line, it's not needed,
Olle Liljenzin 2014/05/05 08:41:40 Done.
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+
+"""Chromium presubmit script for src/net/tools/tld_cleanup."""
+
+
+def _RunMakeDafsaTests(input_api, output_api):
+ """Runs unittest for make_dafsa if any related file has been modified."""
+ files = ('net/tools/tld_cleanup/make_dafsa.py',
+ 'net/tools/tld_cleanup/make_dafsa_unittest.py')
+ if not any(f in input_api.LocalPaths() for f in files):
+ return
+ test_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
+ 'make_dafsa_unittest.py')
+ cmd_name = 'make_dafsa_unittest'
+ if input_api.platform == 'win32':
+ # Windows needs some help.
+ cmd = [input_api.python_executable, test_path]
+ else:
+ cmd = [test_path]
+ test_cmd = input_api.Command(
+ name=cmd_name,
+ cmd=cmd,
+ kwargs={},
+ message=output_api.PresubmitPromptWarning)
+ if input_api.verbose:
+ print('Running ' + cmd_name)
M-A Ruel 2014/05/02 16:53:02 The output is already printed when in verbose mode
Olle Liljenzin 2014/05/05 08:41:40 Done.
+ return input_api.RunTests([test_cmd])
+
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _RunMakeDafsaTests(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+ return _RunMakeDafsaTests(input_api, output_api)
« no previous file with comments | « net/net.gyp ('k') | net/tools/tld_cleanup/README » ('j') | net/tools/tld_cleanup/make_dafsa.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698