Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1971793002: Update to handle dsym files that end with a header. (Closed)

Created:
4 years, 7 months ago by dmac
Modified:
4 years, 7 months ago
Reviewers:
Mark Mentovai, ivanpe
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update to handle dsym files that end with a header. dsym files generated by Xcode for swift (Xcode 7.3) end with a header, and the code did not handle that case. BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=689 R=ivanpe@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/1bbe2f29c966242ee86d4a856418b1317637c916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/common/dwarf/dwarf2reader.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
dmac
PTAL
4 years, 7 months ago (2016-05-11 16:54:58 UTC) #3
ivanpe
On 2016/05/11 16:54:58, dmac wrote: > PTAL LGTM
4 years, 7 months ago (2016-05-11 18:13:34 UTC) #5
dmac
Committed patchset #1 (id:1) manually as 1bbe2f29c966242ee86d4a856418b1317637c916 (presubmit successful).
4 years, 7 months ago (2016-05-11 21:10:29 UTC) #8
Mark Mentovai
4 years, 7 months ago (2016-05-12 00:03:41 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698