|
|
DescriptionAdd WebAPK's client library.
Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK
Minting Server, and whether a URL can be handled by a WebAPK.
- It is in WebAPK's client library, which provides APIs for WebAPK host
to communicate with WebAPKs.
- ChromeWebApkHost is introduced to initialize the public key for WebAPK's
signature verification.
BUG=609122
Committed: https://crrev.com/5cb2361c8307d9df549c357b56efe44c256580f3
Cr-Commit-Position: refs/heads/master@{#393674}
Patch Set 1 : #
Total comments: 10
Patch Set 2 : Remove runtime_library. #Patch Set 3 : Add WebApkValidatorTest. #
Total comments: 22
Patch Set 4 : yfriedman@'s comments. #
Total comments: 2
Patch Set 5 : Revert changes in chromium.linux.json. #Patch Set 6 : Add a test. #Patch Set 7 : Add DEPS. #Messages
Total messages: 47 (25 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. BUG=609122 ========== to ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies concerns of WebAPK's versioning. BUG=609122 ==========
Description was changed from ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies concerns of WebAPK's versioning. BUG=609122 ========== to ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies concerns of WebAPK's versioning. BUG=609122 ==========
Description was changed from ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies concerns of WebAPK's versioning. BUG=609122 ========== to ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies WebAPK's versioning. BUG=609122 ==========
Description was changed from ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies WebAPK's versioning. BUG=609122 ========== to ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies WebAPK's versioning. BUG=609122 ==========
Patchset #1 (id:20001) has been deleted
Hi Peter, can you please take a look? Thanks!
hanxi@chromium.org changed reviewers: + pkotwicz@chromium.org
Description was changed from ========== Add WebAPK's client and runtime library. --Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. --Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies WebAPK's versioning. BUG=609122 ========== to ========== Add WebAPK's client and runtime library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies WebAPK's versioning. BUG=609122 ==========
LGTM for libs/client Can you please split the runtime_library part into a separate CL. When upstreaming the runtime library, can you please also upstream: - WebApkServiceImpl.java - The service definition in AndroidManifest.xml https://codereview.chromium.org/1971773002/diff/40001/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/BUILD.gn... chrome/android/BUILD.gn:123: "//chrome/android/webapk/libs/common", Do we need common yet? https://codereview.chromium.org/1971773002/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:10: * Contains functionality needed for Chrome to initialize as a WebApk browser hsot. How about: "Contains functionality needed for Chrome to host WebAPKs." WebApk -> WebAPK hsot -> host https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... File chrome/android/webapk/libs/client/BUILD.gn (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... chrome/android/webapk/libs/client/BUILD.gn:11: "//third_party/android_tools:android_support_v13_java", Do we need this include? https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... File chrome/android/webapk/libs/client/README (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... chrome/android/webapk/libs/client/README:1: This library provides functionalities that a WebAPK's host can use to communicate with WebAPKs. How about: "Library linked into Chrome APK which provides functionality to communicate with WebAPKs." https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... File chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java:22: * Checks whether a URL belongs to a WebAPK, and whether a WebAPK is signed by WebAPK Minting Nit: "by the WebAPK Minting Server."
Description was changed from ========== Add WebAPK's client and runtime library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. Introduce AIDL interface that WebAPK's host browser can delegate tasks to a WebAPK. - It is in WebAPK's runtime library. Any classes in the runtime library will be stored and loaded from Chrome in runtime. It simplifies WebAPK's versioning. BUG=609122 ========== to ========== Add WebAPK's client and runtime library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. BUG=609122 ==========
Description was changed from ========== Add WebAPK's client and runtime library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. BUG=609122 ========== to ========== Add WebAPK's client library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. BUG=609122 ==========
hanxi@chromium.org changed reviewers: + rsesek@chromium.org
Hi Robert, could you please review the validation of WebAPKs in WebApkValidator and ChromeWebApkHost? Thanks! https://codereview.chromium.org/1971773002/diff/40001/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/BUILD.gn... chrome/android/BUILD.gn:123: "//chrome/android/webapk/libs/common", On 2016/05/11 20:52:17, pkotwicz wrote: > Do we need common yet? Removed. https://codereview.chromium.org/1971773002/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:10: * Contains functionality needed for Chrome to initialize as a WebApk browser hsot. On 2016/05/11 20:52:17, pkotwicz wrote: > How about: "Contains functionality needed for Chrome to host WebAPKs." > > WebApk -> WebAPK > hsot -> host Done. https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... File chrome/android/webapk/libs/client/BUILD.gn (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... chrome/android/webapk/libs/client/BUILD.gn:11: "//third_party/android_tools:android_support_v13_java", On 2016/05/11 20:52:17, pkotwicz wrote: > Do we need this include? No, it isn't needed. Removed. https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... File chrome/android/webapk/libs/client/README (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... chrome/android/webapk/libs/client/README:1: This library provides functionalities that a WebAPK's host can use to communicate with WebAPKs. On 2016/05/11 20:52:17, pkotwicz wrote: > How about: "Library linked into Chrome APK which provides functionality to > communicate with WebAPKs." Done. https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... File chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java (right): https://codereview.chromium.org/1971773002/diff/40001/chrome/android/webapk/l... chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java:22: * Checks whether a URL belongs to a WebAPK, and whether a WebAPK is signed by WebAPK Minting On 2016/05/11 20:52:17, pkotwicz wrote: > Nit: "by the WebAPK Minting Server." Done.
Patchset #2 (id:60001) has been deleted
Patchset #2 (id:80001) has been deleted
Code lg, but I'd like to see unit tests for WebApkValidator as well, since it's security-critical code.
Hi Robert, I added a junit test, please take another look, thanks!
hanxi@chromium.org changed reviewers: + yfriedman@chromium.org
https://codereview.chromium.org/1971773002/diff/120001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java (right): https://codereview.chromium.org/1971773002/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:65: WebApkValidator.initWithBrowserHostSignature(EXPECTED_SIGNATURE); can we add the command line flag for webapks to this cl and early-out from init if unset? https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... File chrome/android/webapk/libs/client/BUILD.gn (right): https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/BUILD.gn:14: junit_binary("webapk_client_junit_tests") { I suspect this won't run anywhere if you don't add to the bots. I think you need to add it to "junit_tests" in testing/buildbot/chromium.linux.json https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... File chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java (right): https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:65: @Test nit: move @Test annotation to after comments https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:70: public void testQueryWebAPKPackageReturnWebApkPackageNameWhichCanHandleTheURL() { WebApk (throughout) https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:70: public void testQueryWebAPKPackageReturnWebApkPackageNameWhichCanHandleTheURL() { please add test for non-browsable (should not return a webapk) https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:71: Intent intent; nit: move to L73 (no need to be separate declaration) https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:81: assertTrue(WebApkValidator.queryWebAPKPackage( assertEquals (throughout) https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:104: assertTrue(WebApkValidator.queryWebAPKPackage( assertNull (throughout) https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:127: public void testFindWebAPKPackageReturnNullWhenNoResolvesInfosCorrespondsToWebApk() { s/ResolvesInfosCorresponds/ResolveInfosCorresponding/ https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:138: public void testIsValidWebApkReturnsTrueForValidWebApk() throws NameNotFoundException { please add test for multiple signatures with one match and with no matches https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:152: public void testIsValidWebApkReturnsFalseForInValidWebApk() throws NameNotFoundException { s/InValid/Invalid/
Patchset #4 (id:140001) has been deleted
Hi Yaron: PTAL, thanks! https://codereview.chromium.org/1971773002/diff/120001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java (right): https://codereview.chromium.org/1971773002/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:65: WebApkValidator.initWithBrowserHostSignature(EXPECTED_SIGNATURE); On 2016/05/12 22:11:39, Yaron wrote: > can we add the command line flag for webapks to this cl and early-out from init > if unset? Done. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... File chrome/android/webapk/libs/client/BUILD.gn (right): https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/BUILD.gn:14: junit_binary("webapk_client_junit_tests") { On 2016/05/12 22:11:39, Yaron wrote: > I suspect this won't run anywhere if you don't add to the bots. I think you need > to add it to "junit_tests" in testing/buildbot/chromium.linux.json Good point, added. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... File chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java (right): https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:65: @Test On 2016/05/12 22:11:39, Yaron wrote: > nit: move @Test annotation to after comments Done. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:70: public void testQueryWebAPKPackageReturnWebApkPackageNameWhichCanHandleTheURL() { On 2016/05/12 22:11:40, Yaron wrote: > WebApk (throughout) Done. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:71: Intent intent; On 2016/05/12 22:11:40, Yaron wrote: > nit: move to L73 (no need to be separate declaration) Done. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:81: assertTrue(WebApkValidator.queryWebAPKPackage( On 2016/05/12 22:11:40, Yaron wrote: > assertEquals (throughout) Done. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:104: assertTrue(WebApkValidator.queryWebAPKPackage( On 2016/05/12 22:11:40, Yaron wrote: > assertNull (throughout) Done. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:127: public void testFindWebAPKPackageReturnNullWhenNoResolvesInfosCorrespondsToWebApk() { On 2016/05/12 22:11:40, Yaron wrote: > s/ResolvesInfosCorresponds/ResolveInfosCorresponding/ Done. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:138: public void testIsValidWebApkReturnsTrueForValidWebApk() throws NameNotFoundException { On 2016/05/12 22:11:39, Yaron wrote: > please add test for multiple signatures with one match and with no matches It is possible to update these two tests to cover the cases that you suggested. https://codereview.chromium.org/1971773002/diff/120001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:152: public void testIsValidWebApkReturnsFalseForInValidWebApk() throws NameNotFoundException { On 2016/05/12 22:11:39, Yaron wrote: > s/InValid/Invalid/ Done.
https://codereview.chromium.org/1971773002/diff/120001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java (right): https://codereview.chromium.org/1971773002/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:65: WebApkValidator.initWithBrowserHostSignature(EXPECTED_SIGNATURE); On 2016/05/13 15:42:54, Xi Han wrote: > On 2016/05/12 22:11:39, Yaron wrote: > > can we add the command line flag for webapks to this cl and early-out from > init > > if unset? > > Done. Introduce the command line on Java side. Will introduce the native side flags when we need it.
lgtm but you'll need a new reviewer for the bot change https://codereview.chromium.org/1971773002/diff/160001/chrome/android/webapk/... File chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java (right): https://codereview.chromium.org/1971773002/diff/160001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:195: public void testIsValidWebApkReturnsTrueForWebApkWithMultipleSignaturesWithoutAnyMatched() ReturnsFalse
I suggest doing the bot changes as a separate CL
fine with me On Fri, May 13, 2016 at 11:52 AM <pkotwicz@chromium.org> wrote: > I suggest doing the bot changes as a separate CL > > https://codereview.chromium.org/1971773002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Revert the changes in chromium.linux.json, and will submit a separate CL to add tests in bots. https://codereview.chromium.org/1971773002/diff/160001/chrome/android/webapk/... File chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java (right): https://codereview.chromium.org/1971773002/diff/160001/chrome/android/webapk/... chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java:195: public void testIsValidWebApkReturnsTrueForWebApkWithMultipleSignaturesWithoutAnyMatched() On 2016/05/13 15:50:13, Yaron wrote: > ReturnsFalse :(
Patchset #5 (id:180001) has been deleted
LGTM One more test to consider: testing if a package doesn't start with WEBAPK_PACKAGE_PREFIX
Good idea, added another test.
The CQ bit was checked by hanxi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkotwicz@chromium.org, yfriedman@chromium.org, rsesek@chromium.org Link to the patchset: https://codereview.chromium.org/1971773002/#ps220001 (title: "Add a test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971773002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971773002/220001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #7 (id:240001) has been deleted
hanxi@chromium.org changed reviewers: + dpranke@chromium.org
Hi Dirk, could you please take a look */DEPS? Thanks!
lgtm.
The CQ bit was checked by hanxi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org, pkotwicz@chromium.org, yfriedman@chromium.org Link to the patchset: https://codereview.chromium.org/1971773002/#ps260001 (title: "Add DEPS.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971773002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971773002/260001
Message was sent while issue was closed.
Description was changed from ========== Add WebAPK's client library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. BUG=609122 ========== to ========== Add WebAPK's client library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. BUG=609122 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:260001)
Message was sent while issue was closed.
Description was changed from ========== Add WebAPK's client library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. BUG=609122 ========== to ========== Add WebAPK's client library. Introduce WebApkValidator that verifies whether a WebAPK is signed by WebAPK Minting Server, and whether a URL can be handled by a WebAPK. - It is in WebAPK's client library, which provides APIs for WebAPK host to communicate with WebAPKs. - ChromeWebApkHost is introduced to initialize the public key for WebAPK's signature verification. BUG=609122 Committed: https://crrev.com/5cb2361c8307d9df549c357b56efe44c256580f3 Cr-Commit-Position: refs/heads/master@{#393674} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/5cb2361c8307d9df549c357b56efe44c256580f3 Cr-Commit-Position: refs/heads/master@{#393674} |