Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1971763003: scheduler: Detect when a main thread touch stream turns into a compositor gesture (Closed)

Created:
4 years, 7 months ago by Sami
Modified:
4 years, 7 months ago
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Detect when a main thread touch stream turns into a compositor gesture When a main thread gesture turns into a compositor driven gesture (e.g., because the touch handler didn't preventDefault(), allowing the compositor to scroll), we previously failed to update the detected use case from MAIN_THREAD_GESTURE to COMPOSITOR_GESTURE. This patch makes sure we always update our policy whenever the use case detected from the input stream hanges, ensuring an appropriate scheduling policy is activated. BUG=600202 Committed: https://crrev.com/1fd38c63f6df73d7d9d86f312b02a1c0d4b08d78 Cr-Commit-Position: refs/heads/master@{#393022}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -26 lines) Patch
M components/scheduler/renderer/renderer_scheduler_impl.h View 2 chunks +1 line, -4 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 6 chunks +18 lines, -19 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 1 4 chunks +70 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sami
4 years, 7 months ago (2016-05-11 17:00:25 UTC) #3
alex clarke (OOO till 29th)
lgtm https://codereview.chromium.org/1971763003/diff/1/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc File components/scheduler/renderer/renderer_scheduler_impl_unittest.cc (right): https://codereview.chromium.org/1971763003/diff/1/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc#newcode394 components/scheduler/renderer/renderer_scheduler_impl_unittest.cc:394: scheduler_->ForceUpdatePolicy(); Perhaps assert on the policy - to ...
4 years, 7 months ago (2016-05-11 17:06:52 UTC) #4
Sami
https://codereview.chromium.org/1971763003/diff/1/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc File components/scheduler/renderer/renderer_scheduler_impl_unittest.cc (right): https://codereview.chromium.org/1971763003/diff/1/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc#newcode394 components/scheduler/renderer/renderer_scheduler_impl_unittest.cc:394: scheduler_->ForceUpdatePolicy(); On 2016/05/11 17:06:52, alex clarke wrote: > Perhaps ...
4 years, 7 months ago (2016-05-11 18:00:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971763003/20001
4 years, 7 months ago (2016-05-11 18:00:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 19:23:40 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 19:25:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fd38c63f6df73d7d9d86f312b02a1c0d4b08d78
Cr-Commit-Position: refs/heads/master@{#393022}

Powered by Google App Engine
This is Rietveld 408576698